Traceback: change debug for critical (#2704)

* just change debug for critical

* fix tests

Author: dbeltrankyl

autosubmit/scripts/autosubmit.py

@@ -66,7 +66,7 @@ def exit_from_error(e: BaseException) -> int:
     err_code = 1
     trace = traceback.format_exc()
     try:
-        Log.debug(trace)
+        Log.critical(trace)
     except BaseException:
         print(trace)
 

test/unit/test_lockfile.py

@@ -33,7 +33,7 @@ def test_delete_lockfile(tmp_path):
     assert not fake_lock.exists()
 
 
-def test_log_debug_raises_error(mocker):
+def test_log_critical_raises_error(mocker):
     """TODO: this probably should never happen?"""
 
     def _fn():
@@ -46,9 +46,9 @@ def _fn():
         mocked_log = mocker.patch('autosubmit.scripts.autosubmit.Log')
         mocked_print = mocker.patch('autosubmit.scripts.autosubmit.print')
 
-        mocked_log.debug.side_effect = BaseException()
-
-        exit_from_error(e)
+        mocked_log.critical.side_effect = BaseException()
+        with pytest.raises(BaseException):
+            exit_from_error(e)
 
         assert mocked_print.called
 
@@ -60,11 +60,11 @@ def _fn():
 @pytest.mark.parametrize(
     'exception,debug_calls,critical_calls,delete_called',
     [
-        (ValueError, 1, 1, True),
-        (BaseLockException, 1, 0, False),
-        (AutosubmitCritical, 1, 1, True),
-        (_TEST_EXCEPTION, 2, 1, True),
-        (AutosubmitError, 1, 1, True)
+        (ValueError, 0, 2, True),
+        (BaseLockException, 0, 1, False),
+        (AutosubmitCritical, 0, 2, True),
+        (_TEST_EXCEPTION, 1, 2, True),
+        (AutosubmitError, 0, 2, True)
     ],
     ids=[
         'normal_exception',