Jobs inside wrappers are called with two arguments, conflicts with DestinE setup

[kinow]

In GitLab by @ainagaya on Dec 2, 2024, 09:14

Hello @dbeltrankyl and @kinow,

Autosubmit Version

4.1.11

Expid affected(If applicable)

t02n

Which task has issues? Where is the log(If applicable)

• Full_name: t02n_ASThread_SIM_17329286378836_1_4.out

• Log_Path: /pfs/lustrep3/scratch/project_465000454/aayaiavi/t02n/LOG_t02n/t02n_ASThread_SIM_17329286378836_1_4.out

Summary

In DestinE we have the templates structured with a heather like:

VAR1=${1:-%VAR1%}

Last week we automatized this numeration, so now its all consistent, but the jobs with wrappers are failing because the job is being executed like

./t02n_19790101_default_1_SIM.cmd 0 /pfs/lustrep3/scratch/project_465000454/aayaiavi/t02n/LOG_t02n

I think that we discussed this long ago but I never opened an issue. I think that the arguments were not needed.

Steps to reproduce

(How one can reproduce the issue - this is very important)

What is the current bug behavior?

(What actually happens)

What is the expected correct behavior?

(What you should see instead)

Relevant logs and/or screenshots(if applicable)

(Paste any relevant logs - use code blocks (```) to format console output, logs, and code, as
it's very hard to read otherwise.)

Any other relevant information(if applicable)

Not a hurry, I will remove the ${1:-} in the SIM jobs.

()

[kinow]

In GitLab by @ainagaya on Dec 2, 2024, 09:19

mentioned in issue digital-twins/de_340-2/workflow#735

[kinow]

In GitLab by @mcastril on Dec 2, 2024, 10:07

I took sometime to understand why it would conflict but it's clear now. These int arguments have been there for a while and I never understood the real reason why they were there

[kinow]

In GitLab by @dbeltrankyl on Dec 2, 2024, 10:14

Thanks @ainagaya

I remember this issue from slack. There were some changes in that part but

command = "./" + str(self.template) + " " + str(self.id_run) + " " + os.getcwd()

I still see this one line.. strange; I thought it was changed for

f"timeout {0} {str(self.template)} > {out_path} 2> {err_path}"

during 4.1.11,

But I can't find it in the code

[kinow]

In GitLab by @dbeltrankyl on Dec 2, 2024, 10:20

Ah, I found it, only for vertical wrappers. And it is in the zombies branch

https://earth.bsc.es/gitlab/search?search=f%22timeout+[Autosubmit 3.5.0](https://github.com/BSC-ES/autosubmit/milestone/7)B0%7D+[Autosubmit 3.5.0](https://github.com/BSC-ES/autosubmit/milestone/7)B%7Btemplate_path%7D%7D+[Autosubmit 3.2.0beta](https://github.com/BSC-ES/autosubmit/milestone/3)E+[Autosubmit 3.5.0](https://github.com/BSC-ES/autosubmit/milestone/7)B%7Bout_path%7D%7D+2%3E+[Autosubmit 3.5.0](https://github.com/BSC-ES/autosubmit/milestone/7)B%7Berr_path%7D%7D%22&nav_source=navbar&project_id=58&group_id=4&search_code=true&repository_ref=4.1.11-zombies

[kinow]

Is it this line, @dbeltrankyl ?

https://earth.bsc.es/gitlab/es/autosubmit/-/blob/b848bb0c563ee1e3b89ddb67034c781bd74f3404/autosubmit/platforms/wrappers/wrapper_builder.py#L534

If so, I think that's in master, and if we deploy 4.1.12-dev this feature can be tested with testing suite/dev experiments, without the zombies branch having to be merged?

[kinow]

In GitLab by @dbeltrankyl on Dec 3, 2024, 10:36

Yes

[dbeltrankyl]

The fix is add or equivalent:

command = f"chmod +x {{template_path}}; timeout {0} {{template_path}} > {{out_path}} 2> {{err_path}}"
To horizontal wrapper cmd

Closed duplicated issue.

I'll do it