From b48c822cb61109c98831fc939fafbe9b7332899e Mon Sep 17 00:00:00 2001 From: badahertz52 Date: Thu, 13 Feb 2025 17:23:57 +0900 Subject: [PATCH 1/2] =?UTF-8?q?docs=20:=20=EB=A6=AC=EB=93=9C=EB=AF=B8=20?= =?UTF-8?q?=EC=8B=9C=EC=97=B0=20=EC=98=81=EC=83=81=20=EC=82=AC=EC=9D=B4?= =?UTF-8?q?=EC=A6=88=20=EC=A1=B0=EC=A0=95=20(#69)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 74a581d..f05ec57 100644 --- a/README.md +++ b/README.md @@ -37,7 +37,7 @@ BOOKER는 이러한 문제를 해결하기 위해 등장했어요. 공공 데이 ### 기능 시연 -ver1.0.0 시연 영상 +ver1.0.0 시연 영상

From 0715619092bdc50c29aa7f1ba86be695f4678ac5 Mon Sep 17 00:00:00 2001 From: badahertz52 Date: Fri, 14 Feb 2025 11:37:33 +0900 Subject: [PATCH 2/2] =?UTF-8?q?fix:=20=EB=8F=84=EC=84=9C=20=EB=AA=A9?= =?UTF-8?q?=EB=A1=9D=20=EC=9D=B4=EB=AF=B8=EC=A7=80=20=EC=82=AC=EC=9D=B4?= =?UTF-8?q?=EC=A6=88=20=EC=9D=BC=EA=B4=80=EB=90=98=EA=B2=8C=20=EC=88=98?= =?UTF-8?q?=EC=A0=95,=20=EB=8C=80=EC=B6=9C=20=EB=8D=B0=EC=9D=B4=ED=84=B0?= =?UTF-8?q?=EA=B0=80=20=EC=97=86=EB=8A=94=20=EB=8F=84=EC=84=9C=20=EC=A0=95?= =?UTF-8?q?=EB=B3=B4=20=EC=B2=98=EB=A6=AC=20(#71)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../BookDetails/components/BookCover/index.module.scss | 2 +- .../BookDetails/components/BookCover/index.tsx | 1 + .../BookDetails/components/BookOverview/index.tsx | 10 +++++----- src/components/ScrollObserver/index.tsx | 2 +- src/components/book/BookCover/index.module.scss | 3 ++- src/components/book/BookCover/index.tsx | 8 +++++--- src/components/book/BookItem/_variables.scss | 2 +- .../components/SwipeableBookCard/index.module.scss | 9 +++++++++ src/styles/reset.scss | 1 - 9 files changed, 25 insertions(+), 13 deletions(-) diff --git a/src/app/book/[isbn]/_components/BookDetails/components/BookCover/index.module.scss b/src/app/book/[isbn]/_components/BookDetails/components/BookCover/index.module.scss index 76fd65f..0d57daf 100644 --- a/src/app/book/[isbn]/_components/BookDetails/components/BookCover/index.module.scss +++ b/src/app/book/[isbn]/_components/BookDetails/components/BookCover/index.module.scss @@ -42,9 +42,9 @@ $backdrop-filter-brightness: 110%; -webkit-box-shadow: 0px 0px 40px 6px rgba(9, 9, 9, 0.3); box-shadow: 0px 0px 40px 6px rgba(109, 108, 108, 0.3); border-radius: $img-border-radius; + aspect-ratio: 2/3; width: 20rem; - height: 32rem; img { border-radius: inherit; } diff --git a/src/app/book/[isbn]/_components/BookDetails/components/BookCover/index.tsx b/src/app/book/[isbn]/_components/BookDetails/components/BookCover/index.tsx index 766959a..79a00db 100644 --- a/src/app/book/[isbn]/_components/BookDetails/components/BookCover/index.tsx +++ b/src/app/book/[isbn]/_components/BookDetails/components/BookCover/index.tsx @@ -24,6 +24,7 @@ const BookCoverLayout = ({ bookDetailData }: BookCoverLayoutProps) => { fill placeholder="blur" blurDataURL={gray200BlurDataURL} + quality={100} /> ) : (
diff --git a/src/app/book/[isbn]/_components/BookDetails/components/BookOverview/index.tsx b/src/app/book/[isbn]/_components/BookDetails/components/BookOverview/index.tsx index 20618cb..5cbfe40 100644 --- a/src/app/book/[isbn]/_components/BookDetails/components/BookOverview/index.tsx +++ b/src/app/book/[isbn]/_components/BookDetails/components/BookOverview/index.tsx @@ -11,11 +11,11 @@ interface BookOverviewLoadedProps { const BookOverviewLoaded = ({ bookDetailData }: BookOverviewLoadedProps) => { const { author, publisher, publicationYear, loans, title } = bookDetailData; - const bookSummary = [ - `${author} 저자(글)`, - `${publisher}﹒${publicationYear}년`, - `대출 ${loans.rank}위 (${loans.count}건)`, - ]; + const bookSummary = [`${author} 저자(글)`, `${publisher}﹒${publicationYear}년`]; + + if (loans.count && loans.rank) { + bookSummary.push(`대출 ${loans.rank}위 (${loans.count}건)`); + } return (
diff --git a/src/components/ScrollObserver/index.tsx b/src/components/ScrollObserver/index.tsx index 41a8bf7..9bd6587 100644 --- a/src/components/ScrollObserver/index.tsx +++ b/src/components/ScrollObserver/index.tsx @@ -7,7 +7,7 @@ const ScrollObserver = (props: UseFetchBooksActionProps) => { const { fetchMoreBooksAction, isPending, isLastPage } = useFetchBooksAction(props); const { observerTargetRef } = useObserver({ isLastPage, isPending, fetchMoreBooksAction }); - return <>{!isLastPage &&
}; + return <>{!isLastPage &&
}; }; export default ScrollObserver; diff --git a/src/components/book/BookCover/index.module.scss b/src/components/book/BookCover/index.module.scss index 08b09bf..06393e4 100644 --- a/src/components/book/BookCover/index.module.scss +++ b/src/components/book/BookCover/index.module.scss @@ -4,9 +4,10 @@ .imgWrapper { position: relative; aspect-ratio: 2/3; - & > img { border-radius: var(--book-cover-border-radius); + width: inherit; + height: auto; } } diff --git a/src/components/book/BookCover/index.tsx b/src/components/book/BookCover/index.tsx index 95c8e33..e87149d 100644 --- a/src/components/book/BookCover/index.tsx +++ b/src/components/book/BookCover/index.tsx @@ -6,13 +6,13 @@ import NoCoverImg from '@/images/noCover.svg'; import { BookItemData } from '@/types'; import styles from './index.module.scss'; - interface BookCoverLoadedProps { + imgWidth?: number; classNameForWidth: string; bookItemData: BookItemData; } -const BookCoverLoaded = ({ bookItemData, classNameForWidth }: BookCoverLoadedProps) => { +const BookCoverLoaded = ({ bookItemData, classNameForWidth, imgWidth = 100 }: BookCoverLoadedProps) => { return (
); diff --git a/src/components/book/BookItem/_variables.scss b/src/components/book/BookItem/_variables.scss index e7dab8b..d4fb88b 100644 --- a/src/components/book/BookItem/_variables.scss +++ b/src/components/book/BookItem/_variables.scss @@ -1,2 +1,2 @@ $img__width-basic: 8rem; -$img__width-small: 7rem; +$img__width-small: 6rem; diff --git a/src/components/carousel/SwipeableCarousel/components/SwipeableBookCard/index.module.scss b/src/components/carousel/SwipeableCarousel/components/SwipeableBookCard/index.module.scss index b6e5143..3e96783 100644 --- a/src/components/carousel/SwipeableCarousel/components/SwipeableBookCard/index.module.scss +++ b/src/components/carousel/SwipeableCarousel/components/SwipeableBookCard/index.module.scss @@ -1,6 +1,7 @@ @use '@/styles/mixins' as mixins; $img__width-basic: 10rem; +$img__width-small: 7rem; .container { display: flex; @@ -8,10 +9,18 @@ $img__width-basic: 10rem; align-items: center; gap: 1rem; width: $img__width-basic; + + @media screen and (max-width: 425px) { + width: $img__width-small; + } } .cover { width: $img__width-basic; + + @media screen and (max-width: 425px) { + width: $img__width-small; + } } .bookInfo { diff --git a/src/styles/reset.scss b/src/styles/reset.scss index 630fe63..e30f218 100644 --- a/src/styles/reset.scss +++ b/src/styles/reset.scss @@ -77,7 +77,6 @@ a:not([class]) { img, picture { display: block; - max-width: 100%; } /* Inherit fonts for inputs and buttons */