Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change CSS variables names. Make them better. more human-friendly. #29

Open
zberwaldt opened this issue Aug 24, 2021 · 4 comments · May be fixed by #56
Open

change CSS variables names. Make them better. more human-friendly. #29

zberwaldt opened this issue Aug 24, 2021 · 4 comments · May be fixed by #56
Assignees
@zberwaldt @moshejs
Labels
good first issue Good for newcomers help wanted Extra attention is needed Low Priority Would be nice to fix, but low on the totem pole

Comments

@zberwaldt
Copy link
Contributor

zberwaldt commented Aug 24, 2021 •
edited
Loading

CSS variables are generic and need to be changed to be more descriptive.
All references to them in styles.ts and components need to be updated as well.

https://github.com/BanklessDAO/bankless-dao-ghost-website/blob/develop/theme/styles.ts#L6-L16
@zberwaldt zberwaldt added good first issue Good for newcomers help wanted Extra attention is needed Low Priority Would be nice to fix, but low on the totem pole labels Aug 24, 2021
@kbhavre
Copy link

kbhavre commented Aug 24, 2021

@zberwaldt please assign this issue to me i would like to work on this issue

@zberwaldt
Copy link
Contributor Author

@kbhavre You should introduce yourself in the website channel on the discord so you get credit and compensated for your work.

@kbhavre
Copy link

kbhavre commented Aug 25, 2021

Can you please share discord link here

@zberwaldt
Copy link
Contributor Author

https://discord.com/invite/bjPz2w9Zts

Ping me on there so I can get you a guest pass. Username is the same as on here @zberwaldt

@zberwaldt zberwaldt assigned zberwaldt and moshejs and unassigned kbhavre Sep 4, 2021
@zberwaldt zberwaldt linked a pull request Sep 10, 2021 that will close this issue
cryptobilla's style refactor #56
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zberwaldt zberwaldt

@moshejs moshejs

Labels
good first issue Good for newcomers help wanted Extra attention is needed Low Priority Would be nice to fix, but low on the totem pole
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cryptobilla's style refactor BanklessDAO/bankless-dao-ghost-website
3 participants
@zberwaldt @moshejs @kbhavre