[Enhancement proposal]: Remove fallback code for < iOS 11 and < macOS 10.11

[jmagman]

Please check the following before submitting a new issue.

• I have searched the existing issues.
• I have carefully read the documentation and verified I have added the required platform specific configuration.

Please select affected platform(s)

• Android
• iOS
• Linux
• macOS
• Web
• Windows

Proposal

geolocator_apple runs on a minimum of iOS 11 and macOS 10.11

flutter-geolocator/geolocator_apple/ios/geolocator_apple.podspec

Line 20 in df61d4c

s.platform = :ios, '11.0'

flutter-geolocator/geolocator_apple/macos/geolocator_apple.podspec

Line 19 in df61d4c

s.platform = :osx, '10.11'

Remove the dead @available fallback code for versions older than these. Some examples:

flutter-geolocator/geolocator_apple/ios/Classes/GeolocatorPlugin.m

Line 178 in df61d4c

if (@available(iOS 10, *)) {

flutter-geolocator/geolocator_apple/ios/Classes/Utils/LocationMapper.m

Line 34 in df61d4c

if (@available(iOS 10.0, *)) {

Pitch

Removing dead code is good!

[jmagman]

Modified from my closed, confusing first issue #1651 (comment):

I'm filing this as a one-off to gelocator (and flutter-permission-handler Baseflow/flutter-permission-handler#1455) because it calls the deprecated -[UIApplication openURL:] totally safely behind an iOS 8.0 availability check

flutter-geolocator/geolocator_apple/ios/Classes/GeolocatorPlugin.m

Lines 185 to 187 in df61d4c

	} else if (@available(iOS 8.0, *)) {
	BOOL success = [[UIApplication sharedApplication]
	openURL:[NSURL URLWithString:UIApplicationOpenSettingsURLString]];

This particular deprecated API has a nasty bug where it will always return NO on newer versions of iOS:

Calling this method has no effect. Use the openURL:options:completionHandler: method instead.

https://developer.apple.com/documentation/uikit/uiapplication/openurl(_:)

gelocator would not hit that bug because of the correct and safe availability check. However, Flutter is being used within Google where maintainers are trying to add linters to avoid this API from being called, and that linter doesn't understand availability. Instead of teaching the linter about availability, it would instead be easier (for them, not you) to remove this usage within geolocator.

It's dead anyway, so even if this cleanup task only removed -[UIApplication openURL:] I would be happy. :)

[TimHoogstrate]

This is merged, I'll close this issue for now. Feel free to reopen when needed.

Kind regards,