[Bug]: Cyborgs can't use the dropitem hotkey to store modules anymore

[Gilgaxx]

BYOND Version

514.1589

Round Date

2025/01/20

Round ID

N/A

Test merges

This is the TM list for today, which I don't think changed from last night when I tried this:
#9124: 'Enable serverside 515.1614' by Crossedfall at commit 1b8f225
#11967: 'Puts life() on delta_time' by Tsar-Salat at commit 0211775
#12046: '[Port-Ish] Adds leaning to the game' by XeonMations at commit b3ab7b9

Describe the bug

When I was walking around as an AI shell, I noticed I was having troubles unequiping modules, since for some reason I thought Q would work but it didn't. After I was attacked by carps and couldn't equip a welder because my muscle memory kept screaming at me to hit Q to unquip one of my modules.

What did you expect?

I used LOOC to ask one of my fellow cyborgs and they also confirmed Q didn't work and you needed to click on the "store tool" button on the bottom right. After asking on the discord I was told that yes it did use to be a thing and I wasn't insane, and it might've been due to #11991 which messed with some keybindings, but I'm not so sure if that's the case.

Reproducible steps

1. Spawn in as a cyborg
2. Equip tool
3. Hit Q to unequip
4. It doesn't do anything

[aramix273]

this piece of code handles multiple keybinds on same key, ordering decreasingly based on weights defined in code

the two keybindings conflicting here are drop_item and unequip_module - drop_item is for humans, while unequip_module is for robots

before #11991, priorities looked like this

after it, priorities look like this

the defined priorities before

and the defined priorities after

tl;dr: when two keybinds are conflicting, they are resolved by priorities, and if that one can be used and works, the second one isn't executed anymore - priorities were changed making drop_item run before unequip_module and the game seems satisfied with what it does so that it doesn't run unequip_module
reverting to old priorities could be a solution but I'm unsure of consequences