Throw when when calling Enum::getDescription() with invalid values

Author: spawnia

src/Enum.php

@@ -56,7 +56,7 @@ abstract class Enum implements EnumContract, Castable, Arrayable, JsonSerializab
     public function __construct(mixed $enumValue)
     {
         if (! static::hasValue($enumValue)) {
-            throw new InvalidEnumMemberException($enumValue, $this);
+            throw new InvalidEnumMemberException($enumValue, static::class);
         }
 
         $this->value = $enumValue;
@@ -302,7 +302,8 @@ public static function getValues(string|array|null $keys = null): array
      */
     public static function getKey(mixed $value): string
     {
-        return array_search($value, static::getConstants(), true);
+        return array_search($value, static::getConstants(), true)
+            ?: throw new InvalidEnumMemberException($value, static::class);
     }
 
     /**

src/Exceptions/InvalidEnumMemberException.php

@@ -3,18 +3,13 @@
 namespace BenSampo\Enum\Exceptions;
 
 use Exception;
-use BenSampo\Enum\Enum;
 
 class InvalidEnumMemberException extends Exception
 {
     /**
-     * Create an InvalidEnumMemberException.
-     *
-     * @param  mixed  $invalidValue
-     * @param  \BenSampo\Enum\Enum  $enum
-     * @return void
+     * @param class-string<\BenSampo\Enum\Enum> $enum
      */
-    public function __construct($invalidValue, Enum $enum)
+    public function __construct(mixed $invalidValue, string $enum)
     {
         $invalidValueType = gettype($invalidValue);
         $enumValues = implode(', ', $enum::getValues());

tests/EnumAttributeDescriptionTest.php

@@ -2,6 +2,7 @@
 
 namespace BenSampo\Enum\Tests;
 
+use BenSampo\Enum\Exceptions\InvalidEnumMemberException;
 use Exception;
 use PHPUnit\Framework\TestCase;
 use BenSampo\Enum\Tests\Enums\DescriptionFromAttribute;
@@ -26,8 +27,10 @@ public function test_an_exception_is_thrown_when_accessing_a_description_which_i
         DescriptionFromAttribute::InvalidCaseWithMultipleDescriptions()->description;
     }
 
-    public function test_an_exception_is_not_thrown_when_accessing_a_description_for_an_invalid_value()
+    public function test_an_exception_is_thrown_when_accessing_a_description_for_an_invalid_value()
     {
-        $this->assertSame('', DescriptionFromAttribute::getDescription('invalid'));
+        $this->expectException(InvalidEnumMemberException::class);
+
+        DescriptionFromAttribute::getDescription('invalid');
     }
 }