Skip to content

Commit 6b78a89

Browse files
committed
PR feedback
1 parent 16f4b98 commit 6b78a89

File tree

2 files changed

+1
-40
lines changed

2 files changed

+1
-40
lines changed

java/client/src/main/java/glide/api/models/BaseTransaction.java

Lines changed: 0 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -5218,25 +5218,6 @@ public T zscan(@NonNull String key, @NonNull String cursor, @NonNull ZScanOption
52185218
* always an <code>Array</code> of the subset of the hash held in <code>key</code>. The array
52195219
* in the second element is always a flattened series of String pairs, where the key is at
52205220
* even indices and the value is at odd indices.
5221-
* @example
5222-
* <pre>{@code
5223-
* // Assume key contains a set with 200 member-score pairs
5224-
* String cursor = "0";
5225-
* Object[] result;
5226-
* do {
5227-
* result = client.hscan(key1, cursor).get();
5228-
* cursor = result[0].toString();
5229-
* Object[] stringResults = (Object[]) result[1];
5230-
*
5231-
* System.out.println("\nHSCAN iteration:");
5232-
* for (int i = 0; i < stringResults.length; i += 2) {
5233-
* System.out.printf("{%s=%s}", stringResults[i], stringResults[i + 1]);
5234-
* if (i + 2 < stringResults.length) {
5235-
* System.out.print(", ");
5236-
* }
5237-
* }
5238-
* } while (!cursor.equals("0"));
5239-
* }</pre>
52405221
*/
52415222
public T hscan(@NonNull String key, @NonNull String cursor) {
52425223
protobufTransaction.addCommands(buildCommand(HScan, buildArgs(key, cursor)));
@@ -5256,25 +5237,6 @@ public T hscan(@NonNull String key, @NonNull String cursor) {
52565237
* always an <code>Array</code> of the subset of the hash held in <code>key</code>. The array
52575238
* in the second element is always a flattened series of String pairs, where the key is at
52585239
* even indices and the value is at odd indices.
5259-
* @example
5260-
* <pre>{@code
5261-
* // Assume key contains a set with 200 member-score pairs
5262-
* String cursor = "0";
5263-
* Object[] result;
5264-
* do {
5265-
* result = client.hscan(key1, cursor, HScanOptions.builder().matchPattern("*").count(20L).build()).get();
5266-
* cursor = result[0].toString();
5267-
* Object[] stringResults = (Object[]) result[1];
5268-
*
5269-
* System.out.println("\nHSCAN iteration:");
5270-
* for (int i = 0; i < stringResults.length; i += 2) {
5271-
* System.out.printf("{%s=%s}", stringResults[i], stringResults[i + 1]);
5272-
* if (i + 2 < stringResults.length) {
5273-
* System.out.print(", ");
5274-
* }
5275-
* }
5276-
* } while (!cursor.equals("0"));
5277-
* }</pre>
52785240
*/
52795241
public T hscan(@NonNull String key, @NonNull String cursor, @NonNull HScanOptions hScanOptions) {
52805242
final ArgsArray commandArgs =

java/integTest/src/test/java/glide/TransactionTestUtilities.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -347,8 +347,7 @@ private static Object[] hashCommands(BaseTransaction<?> transaction) {
347347
String hashKey1 = "{HashKey}-1-" + UUID.randomUUID();
348348

349349
// This extra key is for HScan testing. It is a key with only one field. HScan doesn't guarantee
350-
// a
351-
// return order but this test compares arrays so order is significant.
350+
// a return order but this test compares arrays so order is significant.
352351
String hashKey2 = "{HashKey}-2-" + UUID.randomUUID();
353352

354353
transaction

0 commit comments

Comments
 (0)