From 80b7a9f74f811c536a4237e72a85f0603d771677 Mon Sep 17 00:00:00 2001 From: James Duong Date: Fri, 28 Jun 2024 11:37:54 -0700 Subject: [PATCH] PR feedback --- .../glide/api/models/BaseTransaction.java | 38 ------------------- .../java/glide/TransactionTestUtilities.java | 3 +- 2 files changed, 1 insertion(+), 40 deletions(-) diff --git a/java/client/src/main/java/glide/api/models/BaseTransaction.java b/java/client/src/main/java/glide/api/models/BaseTransaction.java index ced7b6ca01..08a428f005 100644 --- a/java/client/src/main/java/glide/api/models/BaseTransaction.java +++ b/java/client/src/main/java/glide/api/models/BaseTransaction.java @@ -5218,25 +5218,6 @@ public T zscan(@NonNull String key, @NonNull String cursor, @NonNull ZScanOption * always an Array of the subset of the hash held in key. The array * in the second element is always a flattened series of String pairs, where the key is at * even indices and the value is at odd indices. - * @example - *
{@code
-     * // Assume key contains a set with 200 member-score pairs
-     * String cursor = "0";
-     * Object[] result;
-     * do {
-     *   result = client.hscan(key1, cursor).get();
-     *   cursor = result[0].toString();
-     *   Object[] stringResults = (Object[]) result[1];
-     *
-     *   System.out.println("\nHSCAN iteration:");
-     *   for (int i = 0; i < stringResults.length; i += 2) {
-     *     System.out.printf("{%s=%s}", stringResults[i], stringResults[i + 1]);
-     *     if (i + 2 < stringResults.length) {
-     *       System.out.print(", ");
-     *     }
-     *   }
-     * } while (!cursor.equals("0"));
-     * }
*/ public T hscan(@NonNull String key, @NonNull String cursor) { protobufTransaction.addCommands(buildCommand(HScan, buildArgs(key, cursor))); @@ -5256,25 +5237,6 @@ public T hscan(@NonNull String key, @NonNull String cursor) { * always an Array of the subset of the hash held in key. The array * in the second element is always a flattened series of String pairs, where the key is at * even indices and the value is at odd indices. - * @example - *
{@code
-     * // Assume key contains a set with 200 member-score pairs
-     * String cursor = "0";
-     * Object[] result;
-     * do {
-     *   result = client.hscan(key1, cursor, HScanOptions.builder().matchPattern("*").count(20L).build()).get();
-     *   cursor = result[0].toString();
-     *   Object[] stringResults = (Object[]) result[1];
-     *
-     *   System.out.println("\nHSCAN iteration:");
-     *   for (int i = 0; i < stringResults.length; i += 2) {
-     *     System.out.printf("{%s=%s}", stringResults[i], stringResults[i + 1]);
-     *     if (i + 2 < stringResults.length) {
-     *       System.out.print(", ");
-     *     }
-     *   }
-     * } while (!cursor.equals("0"));
-     * }
*/ public T hscan(@NonNull String key, @NonNull String cursor, @NonNull HScanOptions hScanOptions) { final ArgsArray commandArgs = diff --git a/java/integTest/src/test/java/glide/TransactionTestUtilities.java b/java/integTest/src/test/java/glide/TransactionTestUtilities.java index 897ed70ad5..2ad647026e 100644 --- a/java/integTest/src/test/java/glide/TransactionTestUtilities.java +++ b/java/integTest/src/test/java/glide/TransactionTestUtilities.java @@ -347,8 +347,7 @@ private static Object[] hashCommands(BaseTransaction transaction) { String hashKey1 = "{HashKey}-1-" + UUID.randomUUID(); // This extra key is for HScan testing. It is a key with only one field. HScan doesn't guarantee - // a - // return order but this test compares arrays so order is significant. + // a return order but this test compares arrays so order is significant. String hashKey2 = "{HashKey}-2-" + UUID.randomUUID(); transaction