Skip to content

Commit 94daff9

Browse files
committed
ci: remove actions using Rust nightly
Nightly quite often breaks CI by introducing new clippy linters etc, which disrupts one's work when one wants to land a PR whose CI suddenly fails for unrelated reasons. Sometimes, the new linters are also broken and result in false positives. The one that prompted this commit is a false positive about needless_return like this: rust-lang/rust-clippy#13526 ``` error: unneeded `return` statement --> tests/simulator_tests.rs:212:51 | 212 | for simulator_filename in simulator_filenames { | ___________________________________________________^ 213 | | println!("Simulator tests using {}", simulator_filename); 214 | | let _server = Server::launch(&simulator_filename); ... | 244 | | test_btc(&paired_bitbox).await 245 | | } ``` (there is no return statement)
1 parent 6dd99fd commit 94daff9

File tree

1 file changed

+0
-22
lines changed

1 file changed

+0
-22
lines changed

.github/workflows/rust.yml

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -45,28 +45,6 @@ jobs:
4545
sudo apt-get install -y libudev-dev
4646
./ci.sh
4747
48-
49-
Nightly:
50-
name: Test - nightly toolchain
51-
runs-on: ubuntu-latest
52-
strategy:
53-
fail-fast: false
54-
steps:
55-
- uses: actions/checkout@v3
56-
- uses: dtolnay/rust-toolchain@nightly
57-
with:
58-
components: clippy, rustfmt
59-
- name: Enable simulators caching
60-
uses: actions/cache@v4
61-
with:
62-
key: ${{runner.os}}-simulators-cache-${{hashFiles('./tests/simulators.json')}}
63-
path: |
64-
./tests/simulators
65-
- run: |
66-
sudo apt-get update
67-
sudo apt-get install -y libudev-dev
68-
./ci.sh
69-
7048
WASM:
7149
name: WASM and Sandbox
7250
runs-on: ubuntu-latest

0 commit comments

Comments
 (0)