Skip to content

Commit 405ff02

Browse files
authored
Merge pull request gopherjs#1131 from nevkontakte/go1.18
Triage remaining gorepo test failures in 1.18
2 parents fe457d0 + d92466f commit 405ff02

File tree

3 files changed

+13
-7
lines changed

3 files changed

+13
-7
lines changed

compiler/natives/fs_vfsdata.go

+5-5
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

compiler/natives/src/reflect/reflect.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -495,7 +495,7 @@ func StructOf(fields []StructField) Type {
495495
}
496496
}
497497

498-
if _, dup := fset[name]; dup {
498+
if _, dup := fset[name]; dup && name != "_" {
499499
panic("reflect.StructOf: duplicate field " + name)
500500
}
501501
fset[name] = struct{}{}

tests/gorepo/run.go

+7-1
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,6 @@ var knownFails = map[string]failReason{
8585
"fixedbugs/issue14646.go": {category: unsureIfGopherJSSupportsThisFeature, desc: "tests runtime.Caller behavior in a deferred func in SSA backend... does GopherJS even support runtime.Caller?"},
8686
"fixedbugs/issue15039.go": {desc: "valid bug but deal with after Go 1.7 support is out? it's likely not a regression"},
8787
"fixedbugs/issue15281.go": {desc: "also looks valid but deal with after Go 1.7 support is out? it's likely not a regression"},
88-
"fixedbugs/issue15975.go": {desc: "also looks valid but deal with after Go 1.7 support is out?"},
8988

9089
// These are new tests in Go 1.8.
9190
"fixedbugs/issue17381.go": {category: unsureIfGopherJSSupportsThisFeature, desc: "tests runtime.{Callers,FuncForPC} behavior in a deferred func with garbage on stack... does GopherJS even support runtime.{Callers,FuncForPC}?"},
@@ -150,6 +149,13 @@ var knownFails = map[string]failReason{
150149

151150
// These are new tests in Go 1.17.8
152151
"fixedbugs/issue50854.go": {category: lowLevelRuntimeDifference, desc: "negative int32 overflow behaves differently in JS"},
152+
153+
// These are new tests in Go 1.18
154+
"fixedbugs/issue46938.go": {category: notApplicable, desc: "tests -d=checkptr compiler mode, which GopherJS doesn't support"},
155+
"fixedbugs/issue47928.go": {category: notApplicable, desc: "//go:nointerface is a part of GOEXPERIMENT=fieldtrack and is not supported by GopherJS"},
156+
"fixedbugs/issue49665.go": {category: other, desc: "attempts to pass -gcflags=-G=3 to enable generics, GopherJS doesn't expect the flag; re-enable in Go 1.19 where the flag is removed"},
157+
"fixedbugs/issue48898.go": {category: other, desc: "https://github.com/gopherjs/gopherjs/issues/1128"},
158+
"fixedbugs/issue48536.go": {category: usesUnsupportedPackage, desc: "https://github.com/gopherjs/gopherjs/issues/1130"},
153159
}
154160

155161
type failCategory uint8

0 commit comments

Comments
 (0)