Skip to content

Commit 9c7b3f9

Browse files
committed
Skip 3 gorepo tests that attempt to pass unsupported flags:
- fixedbugs/issue46938.go tests checkptr mode, which is unapplicable to GopherJS. - fixedbugs/issue47928.go tests //go:nointerface pragma, which is not a part of the Go spec. - fixedbugs/issue49665.go will be re-enabled in Go 1.19, where -G=3 flag is removed; it would have passed if not for the unsupported flag.
1 parent fe457d0 commit 9c7b3f9

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

tests/gorepo/run.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -150,6 +150,11 @@ var knownFails = map[string]failReason{
150150

151151
// These are new tests in Go 1.17.8
152152
"fixedbugs/issue50854.go": {category: lowLevelRuntimeDifference, desc: "negative int32 overflow behaves differently in JS"},
153+
154+
// These are new tests in Go 1.18
155+
"fixedbugs/issue46938.go": {category: notApplicable, desc: "tests -d=checkptr compiler mode, which GopherJS doesn't support"},
156+
"fixedbugs/issue47928.go": {category: notApplicable, desc: "//go:nointerface is a part of GOEXPERIMENT=fieldtrack and is not supported by GopherJS"},
157+
"fixedbugs/issue49665.go": {category: other, desc: "attempts to pass -gcflags=-G=3 to enable generics, GopherJS doesn't expect the flag; re-enable in Go 1.19 where the flag is removed"},
153158
}
154159

155160
type failCategory uint8

0 commit comments

Comments
 (0)