-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[API] Endpoint for adding/updating user info #132
Comments
@PranshuNayak, I am removing this assignment as there are few others assigned to you which you can work on and others can take these tasks up. |
I'm working on this. |
I'm a little confused which model is to be serialized for the endpoint. |
How about creating a serializer for User, and have three fields in it for student, faculty, staff. This is nested serialization: https://www.django-rest-framework.org/api-guide/relations/#nested-relationships |
Exactly what I wanted. Thanks. |
Does this endpoint also creates users? |
Yeah, you can create 2 endpoints one for updating and one for creating. |
@arminpatel raise 2 separate CLs. One for Create and another for Update |
what are CLs? 😅 |
Sorry, got confused between internal terminology and external. It's called a changelist same as pull request. So raise two PRs separately for update and create. |
Who will have permission to update user? |
I think only the user should have permission to edit their profile details. |
Admin user should have permission to edit user information as well. |
No description provided.
The text was updated successfully, but these errors were encountered: