Skip to content

Commit

Permalink
fix(abstract-utxo): fix presignTransaction for descriptor wallets
Browse files Browse the repository at this point in the history
Short circuit presignTransaction for descriptor wallets

Issue: BTC-1801
  • Loading branch information
OttoAllmendinger committed Jan 28, 2025
1 parent 5155cad commit 2702580
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion modules/abstract-utxo/src/abstractUtxoCoin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,8 @@ import { toBip32Triple, UtxoKeychain, UtxoNamedKeychains } from './keychains';
import { verifyKeySignature, verifyUserPublicKey } from './verifyKey';
import { getPolicyForEnv } from './descriptor/validatePolicy';
import { signTransaction } from './transaction/signTransaction';
import { UtxoWallet } from './wallet';
import { isUtxoWalletData, UtxoWallet } from './wallet';
import { isDescriptorWalletData } from './descriptor/descriptorWallet';

import ScriptType2Of3 = utxolib.bitgo.outputScripts.ScriptType2Of3;

Expand Down Expand Up @@ -1094,6 +1095,9 @@ export abstract class AbstractUtxoCoin extends BaseCoin {
}

async presignTransaction(params: PresignTransactionOptions): Promise<any> {
if (params.walletData && isUtxoWalletData(params.walletData) && isDescriptorWalletData(params.walletData)) {
return params;
}
// In the case that we have a 'psbt-lite' transaction format, we want to indicate in signing to not fail
const txHex = (params.txHex ?? params.txPrebuild?.txHex) as string;
if (
Expand Down

0 comments on commit 2702580

Please sign in to comment.