Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: onboarding shrap,block,bito,mv,vchf,veur,vchf,veur,dmp #5632

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: onboarding shrap,block,bito,mv,vchf,veur,vchf,veur,dmp #5632

wants to merge 1 commit into from
+2,815 −2,652

Conversation

prithvishet2503
Copy link
Contributor

Ticket: WIN-4720

@prithvishet2503 prithvishet2503 requested review from a team as code owners February 25, 2025 13:04
parasgarg-bitgo
parasgarg-bitgo requested changes Feb 25, 2025
View reviewed changes
modules/statics/src/base.ts Outdated
Comment on lines 347 to 348
'arb:veur' = 'arbveur',
'arb:vchf' = 'arbvchf',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'arb:veur' = 'arb:veur',
'arb:vchf' = 'arb:vchf',

zahin-mohammad
zahin-mohammad previously approved these changes Feb 25, 2025
View reviewed changes
@sandra-wang-bitgo
Copy link
Contributor

plz resolve conflict
flushing

@prithvishet2503 prithvishet2503 force-pushed the WIN-4720 branch 3 times, most recently from 7259cdf to 4f178f2 Compare February 27, 2025 11:36
@parasgarg-bitgo parasgarg-bitgo self-requested a review February 27, 2025 11:46
parasgarg-bitgo
parasgarg-bitgo reviewed Feb 27, 2025
View reviewed changes
modules/statics/src/coins/erc20Coins.ts Outdated
'eth:ultra',
'Ultra',
6,
'0x50293DD8889B931EB3441d2664dce8396640B419',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the contract address needs to be in lowercase for eth tokens

@margueriteblair @prithvishet2503
Merge pull request #5644 from BitGo/rel/latest
f5b5769 
chore(root): publish modules

TICKET: WIN-4720
@prithvishet2503 prithvishet2503 requested a review from a team as a code owner February 27, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parasgarg-bitgo parasgarg-bitgo parasgarg-bitgo left review comments

@zahin-mohammad zahin-mohammad zahin-mohammad left review comments

@margueriteblair margueriteblair Awaiting requested review from margueriteblair margueriteblair is a code owner automatically assigned from BitGo/wallet-platform

@mohammadalfaiyazbitgo mohammadalfaiyazbitgo Awaiting requested review from mohammadalfaiyazbitgo mohammadalfaiyazbitgo is a code owner automatically assigned from BitGo/wallet-platform

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@prithvishet2503 @sandra-wang-bitgo @zahin-mohammad @parasgarg-bitgo @margueriteblair