clippy: use built-in conversion from bool to numeric

This is really just a stylistic thing, but it makes the code shorter so
I think we should use it.

Author: apoelstra

Cargo.toml

@@ -54,7 +54,7 @@ cast_possible_wrap = "allow"
 cast_sign_loss = "allow"
 # Exhaustive list of pedantic clippy lints
 assigning_clones = "warn"
-bool_to_int_with_if = "allow"
+bool_to_int_with_if = "warn"
 borrow_as_ptr = "warn"
 case_sensitive_file_extension_comparisons = "warn"
 cast_lossless = "allow"

src/value.rs

@@ -155,7 +155,7 @@ impl UIntValue {
             let mut byte = 0u8;
             for _ in 0..8 {
                 let bit = padded_bits.next().unwrap();
-                byte = (byte << 1) | if bit == '1' { 1 } else { 0 };
+                byte = (byte << 1) | u8::from(bit == '1');
             }
             bytes.push(byte);
         }