You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The updated_at date in the json response (i.e. /api/pages) is not modified when the last update modifies only tags.
I think it would be more coherent to change this date when the tags are updated.
Moreover the tags are not listed in the list of elements queried (see #2680), therefore we cannot test for modified tags directly.
Steps to Reproduce
Create a page
Change only the tags (in a different commit)
Request the list of pages
The updated_at date is the creation date instead of the tag modification date.
Expected Behaviour
I expect to have every actions listed in the commits to change the updated_at date. That is :
Every content modification
Every tag modification
Screenshots or Additional Context
I am using Bookstack v21.05.3.
I found the following related issues
Decided it's relevant to entity updated_at since tags are now indexed
alongside content.
- Also fixed tags not applied on shelf.
- Also enforced proper page API update validation.
- Adds tests to cover.
For #3319Fixes#3370
I was on the fence with this once, since this behaviour may come down to opinion due to tags maybe being considered a separate entity in themselves. Could choose either way, update or not update.
That said, since we're now updating the search index for content based on tags, tags could now be considered part of the content hence I agreed It makes sense to update timestamps on tag change.
The functionality has been added in c30a9d3, with testing to cover. This will be part of the next patch release.
Describe the Bug
The updated_at date in the json response (i.e.
/api/pages
) is not modified when the last update modifies only tags.I think it would be more coherent to change this date when the tags are updated.
Moreover the tags are not listed in the list of elements queried (see #2680), therefore we cannot test for modified tags directly.
Steps to Reproduce
The updated_at date is the creation date instead of the tag modification date.
Expected Behaviour
I expect to have every actions listed in the commits to change the updated_at date. That is :
Screenshots or Additional Context
I am using Bookstack v21.05.3.
I found the following related issues
Browser Details
No response
Exact BookStack Version
v21.05.3
PHP Version
No response
Hosting Environment
I unfortunnately do not know any information on the hosting environement.
The text was updated successfully, but these errors were encountered: