Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users can't know they've been slapped/forgiven #99

Closed
s0lst1ce opened this issue Feb 18, 2020 · 6 comments
Closed

Users can't know they've been slapped/forgiven #99

s0lst1ce opened this issue Feb 18, 2020 · 6 comments
Assignees
Labels
bug Something isn't working command issues related to bot commands critical A critical issue that has to be fixed ASAP

Comments

@s0lst1ce
Copy link
Collaborator

Describe the bug
Users can't know they've been slapped/forgiven if they don't have access to the channel the command was issued. This is a big issue, especially for slapping.

Steps to reproduce
Slap a member that do not have access to the current channel.

Expected behavior
Users should know of their current moderation status in a server.

Additional context
A good way to fix this would be to send a copy of the message as a DM to the user if the said user does not have access to the channel.

@s0lst1ce s0lst1ce added bug Something isn't working critical A critical issue that has to be fixed ASAP command issues related to bot commands labels Feb 18, 2020
@s0lst1ce s0lst1ce self-assigned this Feb 18, 2020
@s0lst1ce
Copy link
Collaborator Author

s0lst1ce commented May 4, 2020

@adrienluitot what do you think is the best way to do this? A command to get your slaps in a server (or all servers). Or simply a message in DM when you get slapped? Or both? Do note that the current implementation to get the slaps is quite slow.

@adrienluitot
Copy link

Well, I think the DM is the best thing and also the easier thing to do.
We just need to precise on which server the user was slap.

@s0lst1ce
Copy link
Collaborator Author

s0lst1ce commented May 4, 2020

ofc, this is simple enough though. I'll write something for this. Maybe I should remove the in-server message altogether? It takes a lot of visual space afterall.

@adrienluitot
Copy link

I guess a message on the server is still important, we should just minimize the message on the server to make it less like a boat! 😛

@s0lst1ce
Copy link
Collaborator Author

s0lst1ce commented May 4, 2020

Smart, I'll try and tweak it.

@s0lst1ce s0lst1ce linked a pull request May 6, 2020 that will close this issue
@s0lst1ce
Copy link
Collaborator Author

s0lst1ce commented May 8, 2020

This was fixed alongside #111

@s0lst1ce s0lst1ce closed this as completed May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working command issues related to bot commands critical A critical issue that has to be fixed ASAP
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants