Skip to content

Commit 4578256

Browse files
authored
Merge pull request #5 from BrickworkSoftware/release/1.2
[#149573905] Release/1.2
2 parents 2093572 + f04ed9e commit 4578256

File tree

5 files changed

+51
-97
lines changed

5 files changed

+51
-97
lines changed

Diff for: packages/react-scripts/config/jest/babelTransform.js

-5
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,6 @@ module.exports = babelJest.createTransformer({
2020
}
2121
}],
2222
"css-modules-transform",
23-
// [require.resolve('babel-plugin-react-intl'), {
24-
// messagesDir: './build/messages/',
25-
// // enforceDescriptions: true,
26-
// extractSourceLocation: true,
27-
// }],
2823
'transform-function-bind',
2924
['transform-decorators-legacy']
3025
],

Diff for: packages/react-scripts/config/paths.js

+13-51
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,15 @@ const resolveApp = relativePath => path.resolve(appDirectory, relativePath);
2121

2222
const envPublicUrl = process.env.PUBLIC_URL;
2323

24+
// use realpathSync to resolve symbolic links in path, when asiago is installed using `npm link asiago`
25+
const asiagoLocation = fs.existsSync(resolveApp('node_modules/@brickwork-software/asiago'))
26+
? resolveApp('node_modules/@brickwork-software/asiago')
27+
: resolveApp('..');
28+
const asiagoDirectory = fs.realpathSync(asiagoLocation)
29+
const asiagoNodeModules = path.resolve(asiagoDirectory, 'node_modules')
30+
31+
const resolveOwn = relativePath => path.resolve(__dirname, '..', relativePath);
32+
2433
function ensureSlash(path, needsSlash) {
2534
const hasSlash = path.endsWith('/');
2635
if (hasSlash && !needsSlash) {
@@ -55,66 +64,19 @@ module.exports = {
5564
appPublic: resolveApp('public'),
5665
appHtml: resolveApp('public/index.html'),
5766
appIndexJs: resolveApp('src/index.js'),
67+
asiagoPath: asiagoDirectory,
68+
asiagoNodeModules: asiagoNodeModules,
5869
appPackageJson: resolveApp('package.json'),
5970
appSrc: resolveApp('src'),
71+
appPath: appDirectory,
6072
yarnLockFile: resolveApp('yarn.lock'),
6173
testsSetup: resolveApp('src/setupTests.js'),
6274
appNodeModules: resolveApp('node_modules'),
6375
publicUrl: getPublicUrl(resolveApp('package.json')),
6476
servedPath: getServedPath(resolveApp('package.json')),
6577
};
6678

67-
// @remove-on-eject-begin
68-
const resolveOwn = relativePath => path.resolve(__dirname, '..', relativePath);
6979

70-
// config before eject: we're in ./node_modules/react-scripts/config/
71-
module.exports = {
72-
dotenv: resolveApp('.env'),
73-
appPath: resolveApp('.'),
74-
appBuild: resolveApp('build'),
75-
appPublic: resolveApp('public'),
76-
appHtml: resolveApp('public/index.html'),
77-
appIndexJs: resolveApp('src/index.js'),
78-
appPackageJson: resolveApp('package.json'),
79-
appSrc: resolveApp('src'),
80-
yarnLockFile: resolveApp('yarn.lock'),
81-
testsSetup: resolveApp('src/setupTests.js'),
82-
appNodeModules: resolveApp('node_modules'),
83-
publicUrl: getPublicUrl(resolveApp('package.json')),
84-
servedPath: getServedPath(resolveApp('package.json')),
85-
// These properties only exist before ejecting:
86-
ownPath: resolveOwn('.'),
87-
ownNodeModules: resolveOwn('node_modules'), // This is empty on npm 3
88-
};
8980

90-
const ownPackageJson = require('../package.json');
91-
const reactScriptsPath = resolveApp(`node_modules/${ownPackageJson.name}`);
92-
const reactScriptsLinked =
93-
fs.existsSync(reactScriptsPath) &&
94-
fs.lstatSync(reactScriptsPath).isSymbolicLink();
9581

96-
// config before publish: we're in ./packages/react-scripts/config/
97-
if (
98-
!reactScriptsLinked &&
99-
__dirname.indexOf(path.join('packages', 'react-scripts', 'config')) !== -1
100-
) {
101-
module.exports = {
102-
dotenv: resolveOwn('template/.env'),
103-
appPath: resolveApp('.'),
104-
appBuild: resolveOwn('../../build'),
105-
appPublic: resolveOwn('template/public'),
106-
appHtml: resolveOwn('template/public/index.html'),
107-
appIndexJs: resolveOwn('template/src/index.js'),
108-
appPackageJson: resolveOwn('package.json'),
109-
appSrc: resolveOwn('template/src'),
110-
yarnLockFile: resolveOwn('template/yarn.lock'),
111-
testsSetup: resolveOwn('template/src/setupTests.js'),
112-
appNodeModules: resolveOwn('node_modules'),
113-
publicUrl: getPublicUrl(resolveOwn('package.json')),
114-
servedPath: getServedPath(resolveOwn('package.json')),
115-
// These properties only exist before ejecting:
116-
ownPath: resolveOwn('.'),
117-
ownNodeModules: resolveOwn('node_modules'),
118-
};
119-
}
120-
// @remove-on-eject-end
82+
// Keep these empty lines to make the diff easy to read

Diff for: packages/react-scripts/config/webpack.config.dev.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -114,8 +114,8 @@ module.exports = {
114114
// https://github.com/facebookincubator/create-react-app/issues/253
115115
modules: [
116116
paths.appPath,
117-
// paths.appNodeModules,
118117
path.resolve(paths.asiagoPath),
118+
paths.asiagoNodeModules,
119119
'node_modules',
120120
].concat(
121121
// It is guaranteed to exist because we tweak it in `env.js`

Diff for: packages/react-scripts/package.json

+14-13
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@brickwork-software/react-scripts",
3-
"version": "1.2.2",
3+
"version": "1.2.3",
44
"description": "Configuration and scripts for Brickwork react apps",
55
"repository": "brickworksoftware/create-react-app",
66
"license": "BSD-3-Clause",
@@ -25,13 +25,14 @@
2525
"babel-core": "6.25.0",
2626
"babel-eslint": "7.2.3",
2727
"babel-jest": "20.0.3",
28-
"babel-loader": "7.0.0",
28+
"babel-loader": "7.1.1",
2929
"babel-plugin-css-modules-transform": "^1.2.7",
3030
"babel-plugin-module-resolver": "^2.7.1",
31+
"babel-plugin-react-intl": "^2.3.1",
3132
"babel-plugin-transform-decorators-legacy": "^1.3.4",
3233
"babel-plugin-transform-function-bind": "^6.22.0",
33-
"babel-preset-react-app": "^3.0.0",
34-
"babel-runtime": "6.23.0",
34+
"babel-preset-react-app": "^3.0.2",
35+
"babel-runtime": "6.26.0",
3536
"case-sensitive-paths-webpack-plugin": "2.1.1",
3637
"chalk": "1.1.3",
3738
"css-loader": "0.28.4",
@@ -46,24 +47,24 @@
4647
"extract-text-webpack-plugin": "3.0.0",
4748
"file-loader": "0.11.2",
4849
"fs-extra": "3.0.1",
49-
"html-webpack-plugin": "2.28.0",
50+
"html-webpack-plugin": "2.29.0",
5051
"identity-obj-proxy": "^3.0.0",
5152
"jest": "20.0.4",
5253
"node-sass": "^4.5.3",
5354
"object-assign": "4.1.1",
5455
"postcss-flexbugs-fixes": "3.2.0",
5556
"postcss-loader": "2.0.6",
56-
"promise": "7.1.1",
57-
"react-dev-utils": "^3.0.0",
57+
"promise": "8.0.1",
58+
"react-dev-utils": "^4.0.0",
5859
"react-error-overlay": "^1.0.7",
5960
"sass-loader": "^6.0.6",
60-
"style-loader": "0.17.0",
61-
"sw-precache-webpack-plugin": "0.9.1",
62-
"url-loader": "0.5.8",
63-
"webpack": "2.6.1",
61+
"style-loader": "0.18.0",
62+
"sw-precache-webpack-plugin": "0.11.4",
63+
"url-loader": "0.5.9",
64+
"webpack": "3.5.1",
6465
"webpack-bundle-analyzer": "^2.8.2",
65-
"webpack-dev-server": "2.4.5",
66-
"webpack-manifest-plugin": "1.1.0",
66+
"webpack-dev-server": "2.7.1",
67+
"webpack-manifest-plugin": "1.2.1",
6768
"whatwg-fetch": "2.0.3"
6869
},
6970
"devDependencies": {

Diff for: packages/react-scripts/yarn.lock

+23-27
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ ansi-styles@^3.0.0:
163163
dependencies:
164164
color-convert "^1.0.0"
165165

166-
ansi-styles@^3.1.0, ansi-styles@^3.2.0:
166+
ansi-styles@^3.1.0:
167167
version "3.2.0"
168168
resolved "https://registry.yarnpkg.com/ansi-styles/-/ansi-styles-3.2.0.tgz#c159b8d5be0f9e5a6f346dab94f16ce022161b88"
169169
dependencies:
@@ -1538,6 +1538,10 @@ [email protected], commander@^2.9.0, commander@~2.9.0:
15381538
dependencies:
15391539
graceful-readlink ">= 1.0.0"
15401540

1541+
commander@~2.11.0:
1542+
version "2.11.0"
1543+
resolved "https://registry.yarnpkg.com/commander/-/commander-2.11.0.tgz#157152fd1e7a6c8d98a5b715cf376df928004563"
1544+
15411545
commondir@^1.0.1:
15421546
version "1.0.1"
15431547
resolved "https://registry.yarnpkg.com/commondir/-/commondir-1.0.1.tgz#ddd800da0c66127393cca5950ea968a3aaf1253b"
@@ -3148,9 +3152,9 @@ html-minifier@^3.2.3:
31483152
relateurl "0.2.x"
31493153
uglify-js "3.0.x"
31503154

3151-
html-webpack-plugin@2.28.0:
3152-
version "2.28.0"
3153-
resolved "https://registry.yarnpkg.com/html-webpack-plugin/-/html-webpack-plugin-2.28.0.tgz#2e7863b57e5fd48fe263303e2ffc934c3064d009"
3155+
html-webpack-plugin@2.29.0:
3156+
version "2.29.0"
3157+
resolved "https://registry.yarnpkg.com/html-webpack-plugin/-/html-webpack-plugin-2.29.0.tgz#e987f421853d3b6938c8c4c8171842e5fd17af23"
31543158
dependencies:
31553159
bluebird "^3.4.7"
31563160
html-minifier "^3.2.3"
@@ -3877,7 +3881,7 @@ js-yaml@^3.4.3, js-yaml@^3.7.0:
38773881
argparse "^1.0.7"
38783882
esprima "^3.1.1"
38793883

3880-
js-yaml@^3.5.2, js-yaml@^3.9.1:
3884+
js-yaml@^3.9.1:
38813885
version "3.9.1"
38823886
resolved "https://registry.yarnpkg.com/js-yaml/-/js-yaml-3.9.1.tgz#08775cebdfdd359209f0d2acd383c8f86a6904a0"
38833887
dependencies:
@@ -5481,15 +5485,6 @@ react-error-overlay@^2.0.0:
54815485
settle-promise "1.0.0"
54825486
source-map "0.5.6"
54835487

5484-
react-intl-translations-manager@^5.0.0:
5485-
version "5.0.0"
5486-
resolved "https://registry.yarnpkg.com/react-intl-translations-manager/-/react-intl-translations-manager-5.0.0.tgz#3c78d3e3e44c5804d7a15c60e89c3aefd9d06615"
5487-
dependencies:
5488-
chalk "^1.1.3"
5489-
glob "^7.0.3"
5490-
json-stable-stringify "^1.0.1"
5491-
mkdirp "^0.5.1"
5492-
54935488
"react@^15 || ^16", react@^15.5.4:
54945489
version "15.6.1"
54955490
resolved "https://registry.yarnpkg.com/react/-/react-15.6.1.tgz#baa8434ec6780bde997cdc380b79cd33b96393df"
@@ -6275,15 +6270,15 @@ svgo@^0.7.0:
62756270
sax "~1.2.1"
62766271
whet.extend "~0.9.9"
62776272

6278-
sw-precache-webpack-plugin@0.9.1:
6279-
version "0.9.1"
6280-
resolved "https://registry.yarnpkg.com/sw-precache-webpack-plugin/-/sw-precache-webpack-plugin-0.9.1.tgz#2381ff706fbb6cabdb20a20337de8e58fb49a2a7"
6273+
sw-precache-webpack-plugin@0.11.4:
6274+
version "0.11.4"
6275+
resolved "https://registry.yarnpkg.com/sw-precache-webpack-plugin/-/sw-precache-webpack-plugin-0.11.4.tgz#a695017e54eed575551493a519dc1da8da2dc5e0"
62816276
dependencies:
62826277
del "^2.2.2"
6283-
sw-precache "^5.0.0"
6284-
uglify-js "^2.8.5"
6278+
sw-precache "^5.1.1"
6279+
uglify-js "^3.0.13"
62856280

6286-
sw-precache@^5.0.0:
6281+
sw-precache@^5.1.1:
62876282
version "5.2.0"
62886283
resolved "https://registry.yarnpkg.com/sw-precache/-/sw-precache-5.2.0.tgz#eb6225ce580ceaae148194578a0ad01ab7ea199c"
62896284
dependencies:
@@ -6471,7 +6466,7 @@ [email protected]:
64716466
commander "~2.9.0"
64726467
source-map "~0.5.1"
64736468

6474-
uglify-js@^2.6, uglify-js@^2.8.29, uglify-js@^2.8.5:
6469+
uglify-js@^2.6, uglify-js@^2.8.29:
64756470
version "2.8.29"
64766471
resolved "https://registry.yarnpkg.com/uglify-js/-/uglify-js-2.8.29.tgz#29c5733148057bb4e1f75df35b7a9cb72e6a59dd"
64776472
dependencies:
@@ -6480,6 +6475,13 @@ uglify-js@^2.6, uglify-js@^2.8.29, uglify-js@^2.8.5:
64806475
optionalDependencies:
64816476
uglify-to-browserify "~1.0.0"
64826477

6478+
uglify-js@^3.0.13:
6479+
version "3.0.28"
6480+
resolved "https://registry.yarnpkg.com/uglify-js/-/uglify-js-3.0.28.tgz#96b8495f0272944787b5843a1679aa326640d5f7"
6481+
dependencies:
6482+
commander "~2.11.0"
6483+
source-map "~0.5.1"
6484+
64836485
uglify-to-browserify@~1.0.0:
64846486
version "1.0.2"
64856487
resolved "https://registry.yarnpkg.com/uglify-to-browserify/-/uglify-to-browserify-1.0.2.tgz#6e0924d6bda6b5afe349e39a6d632850a0f882b7"
@@ -6905,12 +6907,6 @@ yallist@^2.1.2:
69056907
version "2.1.2"
69066908
resolved "https://registry.yarnpkg.com/yallist/-/yallist-2.1.2.tgz#1c11f9218f076089a47dd512f93c6699a6a81d52"
69076909

6908-
yaml-loader@^0.5.0:
6909-
version "0.5.0"
6910-
resolved "https://registry.yarnpkg.com/yaml-loader/-/yaml-loader-0.5.0.tgz#86b1982d84a8e429e6647d93de9a0169e1c15827"
6911-
dependencies:
6912-
js-yaml "^3.5.2"
6913-
69146910
yargs-parser@^4.2.0:
69156911
version "4.2.1"
69166912
resolved "https://registry.yarnpkg.com/yargs-parser/-/yargs-parser-4.2.1.tgz#29cceac0dc4f03c6c87b4a9f217dd18c9f74871c"

0 commit comments

Comments
 (0)