ci: improve quality tests

Author: Greg Bowler

phpmd.xml

@@ -32,7 +32,7 @@
 
 	<rule ref="rulesets/naming.xml/ShortVariable">
 		<properties>
-			<property name="exceptions" value="a,b,i" />
+			<property name="exceptions" value="a,b,i,id" />
 		</properties>
 	</rule>
 </ruleset>

src/AuthenticatedRequest.php

@@ -34,7 +34,7 @@ public function __construct(
 		foreach($kvp as $key => $value) {
 			$uri = str_replace(
 				"{" . $key . "}",
-				$value ?? "",
+				$value,
 				$uri,
 			);
 		}

src/Client.php

@@ -70,8 +70,13 @@ private function json(AuthenticatedRequest $authenticatedRequest):?JsonObject {
 			"headers" => $httpHeaders,
 		]);
 		if(!$response->ok) {
-			throw new SpektrixAPIException($response->status);
+			if($response->status === 404) {
+				return null;
+			}
+
+			throw new SpektrixAPIException("HTTP $response->status");
 		}
+
 		return $response->awaitJson();
 	}
 

src/Signature.php

@@ -23,7 +23,16 @@ public function __construct(
 		}
 
 		$decodedSecretKey = base64_decode($secretKeyBase64);
-		$utf8encodedStringToSign = mb_convert_encoding($stringToSign, 'UTF-8', 'ISO-8859-1');
-		$this->signedString = hash_hmac("sha1", $utf8encodedStringToSign, $decodedSecretKey, true);
+		$utf8encodedStringToSign = mb_convert_encoding(
+			$stringToSign,
+			"UTF-8",
+			"ISO-8859-1",
+		);
+		$this->signedString = hash_hmac(
+			"sha1",
+			$utf8encodedStringToSign,
+			$decodedSecretKey,
+			true,
+		);
 	}
 }