Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

l_vcmaxFeedbk inconsistency #239

Open
penguian opened this issue Feb 6, 2020 · 4 comments
Open

l_vcmaxFeedbk inconsistency #239

penguian opened this issue Feb 6, 2020 · 4 comments

Comments

@penguian
Copy link
Collaborator

penguian commented Feb 6, 2020

keyword_keepgit type_defect | by mgk576


In cable_driver, we have the following check:

IF( l_vcmaxFeedbk .AND. icycle < 1 )					   &
       STOP 'icycle must be 2 to 3 to get prognostic Vcmax'

By contrast in the mpi code (cable_mpimaster & mpiworker) we have:

IF( l_vcmaxFeedbk .AND. icycle < 2 )                                     &
         STOP 'icycle must be 2 to 3 to get prognostic Vcmax'

Issue migrated from trac:239 at 2023-11-27 11:31:14 +1100

@penguian
Copy link
Collaborator Author

penguian commented Feb 7, 2020

@[email protected] changed owner from bep599 to mgk561

@penguian
Copy link
Collaborator Author

penguian commented Feb 7, 2020

@[email protected] set milestone to 6. Report

@penguian
Copy link
Collaborator Author

penguian commented Feb 7, 2020

@[email protected] commented


Fix: Milestone="Report"
Owner=mgk561

@penguian
Copy link
Collaborator Author

penguian commented Feb 7, 2023

@[email protected] set keywords to keepgit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant