Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dimensions/initialisation of zetar #522

Closed
har917 opened this issue Jan 10, 2025 · 1 comment
Closed

dimensions/initialisation of zetar #522

har917 opened this issue Jan 10, 2025 · 1 comment

Comments

@har917
Copy link
Collaborator

har917 commented Jan 10, 2025

In define_canopy, comp_friction_vel and update_zetar there is a mismatch between the dimensions of the parent and local instances of the zetar (and zetarsh) variables.

It is not immediately obvious why these variables need to be 2D arrays and it also appears that zetar and zetarsh are only partially initialised.

The impacts of this quirk/bug fix are unknown - but potentially important in coupled simulations.

@har917
Copy link
Collaborator Author

har917 commented Jan 10, 2025

see #521 as the first step in identifying the impact and seriousness of this

@har917 har917 closed this as completed Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant