Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reconcile the default (non-active) values of soil%watr #540

Open
har917 opened this issue Feb 10, 2025 · 0 comments
Open

reconcile the default (non-active) values of soil%watr #540

har917 opened this issue Feb 10, 2025 · 0 comments

Comments

@har917
Copy link
Collaborator

har917 commented Feb 10, 2025

The soil parameter %watr (which I understand to be a GW science parameter) is being initialised in various places through the code to differing values. At least the following exist

  • 0.05 in src/coupled/ESM1.5/CABLEfilesFromESM1.5/allocate_soil_params_cbl.F90
  • 0.0, 0.01, 0.02+clay, and 0.05 in cable_parameters
  • 0.05 in cable_define_types
  • 0.05 and 0.001 in cbl_um_init_soil (AM3)
  • 0.001 in cable_um_init_subrs (ESM1.6)

This needs sorting otherwise we will end up inadvertently using the wrong value at some point and/or forgetting to keep each of these instances in sync with each other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant