Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review how GWspatialParameters work #543

Open
ccarouge opened this issue Feb 10, 2025 · 0 comments
Open

Review how GWspatialParameters work #543

ccarouge opened this issue Feb 10, 2025 · 0 comments
Labels
GWH Ground water hydrology integration work

Comments

@ccarouge
Copy link
Member

For the moment, GWspatialParameters() is called for all simulations so all simulations will try and go read parameters that are only needed when the groundwater is on. It seems it would be best to only call the subroutine when groundwater is on and avoid this subroutine changing values for non-groundwater configurations.

Also, the subroutine tries to read some parameters from file, if it fails, it sets a default for the parameters. This is different from the behaviour for other parameters. The behaviour in CABLE is normally to set the default parameters, then read the input files. The parameters' values for the variables found in the file are updated while the other keep their default allocation.
We need to separate the initialisation to default values for the spatial parameters and the update from file which can stay in GWspatialParameters().
It might be a good idea to set the default values within/called from/called around get_default_params().

@ccarouge ccarouge added the GWH Ground water hydrology integration work label Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GWH Ground water hydrology integration work
Projects
None yet
Development

No branches or pull requests

1 participant