-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calculation of wbliq
when considering different ice and liquid densities
#558
Comments
okay - a couple of points to make here - but basically this comes down to definitions and units (and I think the GW code is wrong or at least different). In soil_snow The ground water equation above appears to indicate that these variables have different definitions - possibly liquid water equivalent volumes (but that doesn't work as it should be density_liq/density_ice), possibly mass of liquid water equivalent per m3 soil In contrast |
@har917 thanks for the input. I confirm that I got the equation as it is in the code so density_ice/density_liq. Also, the GW code calculates:
From what you are saying Ian, we need to differentiate the calculations of |
@ccarouge I'm basically not really happy to comment further without confirmation from the GW people to check/document the units they are using and (implicitly) check that their code is as the intent. I realise that's possibly not possible.
Other things that come into this:
Edit: On reflection I'm wondering whether there are some different assumptions about how to interpret |
Also - a key point - if there has been a change in interpretation e.g. of units then the code coupling GW into AM3 will need to be thoroughly reviewed. |
Yep, understood. Your input was already useful. |
After consulting with Mengyuan (@bibivking), it appears From this and previous comments in this issue, it definitely appears the calculations and usage of |
@ccarouge @bibivking This is sort of what I figured out and is a key point of difference between the parameterisation schemes. (SLI uses We can then note that (unfortunately)
*probably only an issue for runtime diagnostics at the moment, but would be a problem for the rivers within the coupled model. |
Recently, some effort has been made in CABLE to differentiate the ice and liquid water density in soil. Until now, they have been assumed equal.
The groundwater work has done some effort in this direction as well. One difference is that it introduces:
Is this a change we would like to make for CABLE throughout the code? That is, we would change all calculations of
wbliq
in CABLE to introduce the densities.To note that currently
soil_snow
has code like:which seems to introduce inconsistencies between
wb
andwbtot
.@har917 Is that something we want? I realise it can have big implications for coupled simulations. If we don't want to change this entirely in CABLE then we will have to introduce a different calculation of
wbliq
for the GW model which does not seem to make much sense...The text was updated successfully, but these errors were encountered: