Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meorg_client implementation broken #321

Closed
ccarouge opened this issue Jan 15, 2025 · 5 comments · Fixed by #323
Closed

meorg_client implementation broken #321

ccarouge opened this issue Jan 15, 2025 · 5 comments · Fixed by #323
Assignees
Labels
blocked Can't be fixed now. Could depend on another issue. bug Something isn't working

Comments

@ccarouge
Copy link
Member

ccarouge commented Jan 15, 2025

Just tried to use the upload from benchcab to meorg and got this:

Traceback (most recent call last):
  File "/g/data/hh5/public/apps/miniconda3/envs/analysis3-unstable/bin/benchcab", line 10, in <module>
    sys.exit(main())
  File "/g/data/hh5/public/apps/miniconda3/envs/analysis3-24.07/lib/python3.10/site-packages/benchcab/main.py", line 45, in main
    parse_and_dispatch(parser, app)
  File "/g/data/hh5/public/apps/miniconda3/envs/analysis3-24.07/lib/python3.10/site-packages/benchcab/main.py", line 35, in parse_and_dispatch
    func(**args)
  File "/g/data/hh5/public/apps/miniconda3/envs/analysis3-24.07/lib/python3.10/site-packages/benchcab/benchcab.py", line 454, in run
    self.fluxsite_submit_job(config_path, skip)
  File "/g/data/hh5/public/apps/miniconda3/envs/analysis3-24.07/lib/python3.10/site-packages/benchcab/benchcab.py", line 250, in fluxsite_submit_job
    bm.do_meorg(
  File "/g/data/hh5/public/apps/miniconda3/envs/analysis3-24.07/lib/python3.10/site-packages/benchcab/utils/meorg.py", line 60, in do_meorg
    if MeorgClient().is_initialised() == False:
AttributeError: 'Client' object has no attribute 'is_initialised'

It's using conda analysis3/unstable and benchcab v4.2.0, the latest version at the time of running and meorg v0.2.0, also the latest version at time of running.

@bschroeter
Copy link
Collaborator

Looks like we need a new release of the client. There have been changes since 0.2.0 that are yet unreleased.

I'll release 0.3.0, which provides the is_initialised method.

@bschroeter
Copy link
Collaborator

OK, it seems there is a silent failure on the conda publish for the client. Actions are green but the release is not making it to anaconda.

https://github.com/CABLE-LSM/meorg_client/actions/runs/13190012859

Investigating...

@bschroeter
Copy link
Collaborator

Issue is in the conda upload Action. Our best and brightest are on the case.

@ccarouge
Copy link
Member Author

ccarouge commented Feb 9, 2025

Do we have an issue we can link to that will tell us this benchcab issue is "solved"?

@ccarouge ccarouge added bug Something isn't working blocked Can't be fixed now. Could depend on another issue. labels Feb 9, 2025
@bschroeter
Copy link
Collaborator

That would be this one: CABLE-LSM/meorg_client#61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Can't be fixed now. Could depend on another issue. bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants