Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cd probably not working #324

Closed
ccarouge opened this issue Feb 9, 2025 · 8 comments · Fixed by #325
Closed

cd probably not working #324

ccarouge opened this issue Feb 9, 2025 · 8 comments · Fixed by #325
Labels
blocked Can't be fixed now. Could depend on another issue. bug Something isn't working

Comments

@ccarouge
Copy link
Member

ccarouge commented Feb 9, 2025

This meorg_client issue highlighted a problem with the conda deployment action we are using to upload benchcab packages to Anaconda.

We may need to upload by hand, if required, until the issue is solved.

@ccarouge ccarouge added bug Something isn't working blocked Can't be fixed now. Could depend on another issue. labels Feb 9, 2025
@SeanBryan51
Copy link
Collaborator

Should we do a test release with benchcab?

@ccarouge
Copy link
Member Author

If you want to @SeanBryan51 . We will need to do a release once the meorg_client is updated on Anaconda anyway, so we could just wait until then. It could come soon but depends if we do a manual update of the meorg_client package or not. I'm waiting on @bschroeter to have some idea on the timeline.

@SeanBryan51
Copy link
Collaborator

I've pushed a temporary release: https://github.com/CABLE-LSM/benchcab/releases/tag/v4.2.1. Here is the log for conda upload action: https://github.com/CABLE-LSM/benchcab/actions/runs/13233871164

A release should appear if it is successful here: https://anaconda.org/accessnri/benchcab/files

@SeanBryan51
Copy link
Collaborator

Looks like it didn't work!

@bschroeter
Copy link
Collaborator

I've raised this issue upstream: uibcdf/action-build-and-upload-conda-packages#29

This is not the only one...

@bschroeter
Copy link
Collaborator

I can confirm that @SeanBryan51's manual upload commands work, however, it uploaded the previous tag (0.3.1) rather than 0.4.0 for some reason. This is not a big issue as the only change between those tags was updating the version of the upstream action, which is having issues.

TLDR: Set the minimum version of meorg_client to 0.3.1 in whatever configs you have it listed in.

See details here: CABLE-LSM/meorg_client#61

@SeanBryan51
Copy link
Collaborator

SeanBryan51 commented Feb 12, 2025

I've added the workaround to the CD action in #325.

The action is running here: https://github.com/CABLE-LSM/benchcab/actions/runs/13277746527

@SeanBryan51
Copy link
Collaborator

Looks like its working 🙂 I will remove the uploaded test release from anaconda and the GitHub repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Can't be fixed now. Could depend on another issue. bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants