Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Facets being wrongly normalized/lowercased #145

Open
wkdewey opened this issue Jun 17, 2024 · 2 comments · Fixed by #143
Open

Facets being wrongly normalized/lowercased #145

wkdewey opened this issue Jun 17, 2024 · 2 comments · Fixed by #143
Assignees
@wkdewey
Labels
bug

Comments

@wkdewey
Copy link
Contributor

wkdewey commented Jun 17, 2024

See the Periodical facet on https://whitman-dev.unl.edu/whitmanarchive_rails/published-writings/periodicals/journalism. "New-York Times" is being normalized to "newyork times" and the API or Orchid are changing this to "Newyork Times".
@wkdewey wkdewey added the bug label Jun 17, 2024
@wkdewey wkdewey self-assigned this Jun 17, 2024
@wkdewey
Copy link
Contributor Author

wkdewey commented Jun 18, 2024

Update: this is specifically happening on the nested fields we added. Simple non-nested fields are still working as expected.

wkdewey added a commit that referenced this issue Aug 6, 2024
@wkdewey
fix display of nested field facets
f72c307 
Need to adjust for new Elasticsearch hash formatting when finding the non-normalized facet source name

fixes #145
@wkdewey wkdewey linked a pull request Aug 7, 2024 that will close this issue
Local testing #143
Merged
@wkdewey wkdewey mentioned this issue Oct 29, 2024
Open
wkdewey added a commit that referenced this issue Nov 1, 2024
@wkdewey
fix display of nested field facets
18c7b41 
Need to adjust for new Elasticsearch hash formatting when finding the non-normalized facet source name

fixes #145
@nichgray
Copy link

nichgray commented Nov 21, 2024 •
edited
Loading

The nested fields are now working nicely for Cather after the above fix, but two of the non-nested fields are still demonstrating this behavior (rights_holder and rights_uri):

Screenshot 2024-11-21 at 2 41 39 PM

It is possible this is just a minor config adjustment, but adding here to be looked at as time allows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wkdewey wkdewey

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Local testing CDRH/api
2 participants
@nichgray @wkdewey