Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less space for linebreaks? #249

Open
kmcmullen opened this issue Apr 25, 2024 · 4 comments
Open

Less space for linebreaks? #249

kmcmullen opened this issue Apr 25, 2024 · 4 comments
Assignees
Labels
bug Something is broken design design work/decisions high priority

Comments

@kmcmullen
Copy link
Contributor

kmcmullen commented Apr 25, 2024

Just for the correspondence materials, can we change the CSS (I'm assuming it's CSS) so that there is much less space for a <lb/>? Ideally, we'd just like as much space as there is between <addrLine>s or other similar elements.

For example of something with too much space, see the amount of space between "January 18th." and "1921." in the <dateline> here: https://cdrhdev1.unl.edu/chesnutt/item/ccda.corr00786

@kmcmullen kmcmullen added the design design work/decisions label Apr 25, 2024
@kmcmullen kmcmullen added this to the Correspondence grant #2 milestone Apr 25, 2024
@kmcmullen
Copy link
Contributor Author

I have this as "high priority," but if it's not a quick fix, don't worry about it for now.

@erinchambers
Copy link
Contributor

Ah, this is the double <br> thing again (the XSLT is putting in two HTML linebreaks for every TEI linebreak). Stay tuned

@erinchambers
Copy link
Contributor

Sleuthing: anywhere we have <br/> in the XSLT, it's turning into <br></br> in the output HTML - and the browser interprets that as two in a row <br /><br />. That's how we're getting too much spacing. Karin found this solution but that caused the linebreaks not to show up in the output at all

@erinchambers erinchambers added the bug Something is broken label Sep 5, 2024
@erinchambers
Copy link
Contributor

Discussed with @karindalziel and @kmcmullen in Teams. Karin figured out that changing the output to "xml" fixed the problem; the danger is that it will also change other things that are unanticipated.

Decided that we'll make the change soon, when Kevin has more time to do a thorough checking - but not yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken design design work/decisions high priority
Projects
None yet
Development

No branches or pull requests

2 participants