Skip to content

Commit b46df0d

Browse files
committed
Add missing CeedDestroy
1 parent 6eee1ff commit b46df0d

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

backends/hip-ref/ceed-hip-ref-vector.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -305,14 +305,13 @@ static int CeedVectorCopyStrided_Hip(CeedVector vec, CeedSize start, CeedSize st
305305
// Set value for synced device/host array
306306
if (impl->d_array) {
307307
CeedScalar *copy_array;
308+
Ceed ceed;
308309

310+
CeedCallBackend(CeedVectorGetCeed(vec, &ceed));
309311
CeedCallBackend(CeedVectorGetArray(vec_copy, CEED_MEM_DEVICE, &copy_array));
310312
#if (HIP_VERSION >= 60000000)
311313
hipblasHandle_t handle;
312314
hipStream_t stream;
313-
Ceed ceed;
314-
315-
CeedCallBackend(CeedVectorGetCeed(vec, &ceed));
316315
CeedCallBackend(CeedGetHipblasHandle_Hip(ceed, &handle));
317316
CeedCallHipblas(ceed, hipblasGetStream(handle, &stream));
318317
#if defined(CEED_SCALAR_IS_FP32)

backends/hip-shared/ceed-hip-shared-basis.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -489,6 +489,7 @@ static int CeedBasisApplyAtPointsCore_Hip_shared(CeedBasis basis, bool apply_add
489489
CeedCallBackend(CeedVectorRestoreArray(v, &d_v));
490490
if (eval_mode == CEED_EVAL_NONE) CeedCallBackend(CeedVectorSetArray(v, CEED_MEM_DEVICE, CEED_COPY_VALUES, (CeedScalar *)d_u));
491491
if (eval_mode != CEED_EVAL_WEIGHT) CeedCallBackend(CeedVectorRestoreArrayRead(u, &d_u));
492+
CeedCallBackend(CeedDestroy(&ceed));
492493
return CEED_ERROR_SUCCESS;
493494
}
494495

@@ -644,6 +645,7 @@ static int CeedBasisDestroy_Hip_shared(CeedBasis basis) {
644645
CeedCallHip(ceed, hipFree(data->d_collo_grad_1d));
645646
CeedCallHip(ceed, hipFree(data->d_chebyshev_interp_1d));
646647
CeedCallBackend(CeedFree(&data));
648+
CeedCallBackend(CeedDestroy(&ceed));
647649
return CEED_ERROR_SUCCESS;
648650
}
649651

@@ -737,6 +739,7 @@ int CeedBasisCreateH1_Hip_shared(CeedElemTopology topo, CeedInt dim, CeedInt num
737739
if (((size_t)num_nodes * (size_t)num_qpts * (size_t)dim + (size_t)CeedIntMax(num_nodes, num_qpts)) * sizeof(CeedScalar) >
738740
hip_data->device_prop.sharedMemPerBlock) {
739741
CeedCallBackend(CeedBasisCreateH1Fallback(ceed, topo, dim, num_nodes, num_qpts, interp, grad, q_ref, q_weight, basis));
742+
CeedCallBackend(CeedDestroy(&ceed));
740743
return CEED_ERROR_SUCCESS;
741744
}
742745
}

0 commit comments

Comments
 (0)