From c187edbee944e84962d9470f0bb58bf0241996b9 Mon Sep 17 00:00:00 2001 From: "jianchao.ma" Date: Fri, 26 Apr 2024 12:29:53 +0000 Subject: [PATCH] refactor: fix lint error --- cmd/sigo/main.go | 3 +-- pkg/sigo/driver.go | 2 ++ pkg/sigo/driver_test.go | 3 +-- pkg/sigo/validator.go | 3 ++- 4 files changed, 6 insertions(+), 5 deletions(-) diff --git a/cmd/sigo/main.go b/cmd/sigo/main.go index 36ff8a5..97e9130 100644 --- a/cmd/sigo/main.go +++ b/cmd/sigo/main.go @@ -146,7 +146,7 @@ func run(definition pdef, logs logs) { } sink := infra.NewJSONLineSink(os.Stdout) - + var debugger sigo.Debugger if logs.info != "" { @@ -156,7 +156,6 @@ func run(definition pdef, logs logs) { } var cpuProfiler interface{ Stop() } - if logs.profiling { cpuProfiler = profile.Start(profile.ProfilePath(".")) } diff --git a/pkg/sigo/driver.go b/pkg/sigo/driver.go index f2a2ed1..a388ac8 100644 --- a/pkg/sigo/driver.go +++ b/pkg/sigo/driver.go @@ -29,6 +29,7 @@ func Anonymize(source RecordSource, factory GeneralizerFactory, generalizer := factory.New(k, l, dim, source.QuasiIdentifer()) count := 0 records := []Record{} + log.Info().Msg("Reading source") for source.Next() { @@ -43,6 +44,7 @@ func Anonymize(source RecordSource, factory GeneralizerFactory, validator := NewFloat64DataValidator(records, source.QuasiIdentifer()) err := validator.Validation() + if err != nil { return err } diff --git a/pkg/sigo/driver_test.go b/pkg/sigo/driver_test.go index edcb898..9295a04 100644 --- a/pkg/sigo/driver_test.go +++ b/pkg/sigo/driver_test.go @@ -167,9 +167,8 @@ func TestDataValidatorShouldReturnErrorWithNullValue(t *testing.T) { func TestDataValidatorShouldReturnErrorWithList(t *testing.T) { t.Parallel() - + //nolint: go-golangci-lint sourceText := `{"fruit":[0,1],"taille":[1,2],"poids":[1,2],"meurtre":0,"natation":[0,1],"course":[0,1],"voltige":[0,1],"animal":"souris"} - {"fruit":[0,1],"taille":[1,2],"poids":[1,2],"meurtre":0,"natation":[0,1],"course":[0,1],"voltige":[0,1],"animal":"saumon"} {"fruit":[0,1],"taille":[1,2],"poids":[1,2],"meurtre":1,"natation":[0,1],"course":[0,1],"voltige":[0,1],"animal":"chouette"} {"fruit":[0,1],"taille":[1,2],"poids":null,"meurtre":0,"natation":[0,1],"course":[0,1],"voltige":[0,1],"animal":"canard"} {"fruit":[0,1],"taille":[3,3],"poids":[3,4],"meurtre":1,"natation":[0,1],"course":[0,1],"voltige":[0,1],"animal":"loup"} diff --git a/pkg/sigo/validator.go b/pkg/sigo/validator.go index 653f07e..6fb9587 100644 --- a/pkg/sigo/validator.go +++ b/pkg/sigo/validator.go @@ -31,7 +31,6 @@ func NewFloat64DataValidator(records []Record, quasiIdentifers []string) Float64 return Float64DataValidator{records: records, quasiIdentifers: quasiIdentifers} } -// nolint: cyclop func (v Float64DataValidator) Validation() error { for _, record := range v.records { row := record.Row() @@ -44,8 +43,10 @@ func (v Float64DataValidator) Validation() error { return err } + //nolint: gocritic switch t := row[key].(type) { case bool: + //nolint: goerr113 err := fmt.Errorf("unsupported type: %T", t) return err