[cheriot] Add cheriot spellings to calling convention-related attributes.

resistor · resistor · commit 533ea1641ba3 · 2025-02-17T21:49:49.000+13:00
diff --git a/clang/include/clang/Basic/Attr.td b/clang/include/clang/Basic/Attr.td
@@ -2564,7 +2564,8 @@ def CHERICCallee : DeclOrTypeAttr { // InheritableAttr {
 }
 
 def CHERICCallback : DeclOrTypeAttr { // InheritableAttr {
-  let Spellings = [GNU<"cheri_ccallback">];
+  let Spellings = [GNU<"cheri_ccallback">,
+                   GNU<"cheriot_ccallback">];
   let Documentation = [Undocumented];
 }
 
@@ -2580,14 +2581,17 @@ def CHERIMethodClass : DeclOrTypeAttr { // InheritableAttr {
 }
 
 def CHERICompartmentName : DeclOrTypeAttr {
-  let Spellings = [GNU<"cheri_compartment">];
+  let Spellings = [GNU<"cheri_compartment">,
+                   GNU<"cheriot_compartment">];
   let Documentation = [Undocumented];
   let Subjects = SubjectList<[Function], ErrorDiag>;
   let Args = [StringArgument<"CompartmentName">];
 }
 
 def CHERILibCall : DeclOrTypeAttr {
-  let Spellings = [GNU<"cheri_libcall">];
+  let Spellings = [GNU<"cheri_libcall">,
+                   GNU<"cheriot_libcall">
+                   ];
   let Documentation = [Undocumented];
   let Subjects = SubjectList<[Function], ErrorDiag>;
 }
diff --git a/clang/lib/Basic/Targets/RISCV.cpp b/clang/lib/Basic/Targets/RISCV.cpp
@@ -246,9 +246,9 @@ void RISCVTargetInfo::getTargetDefines(const LangOptions &Opts,
 
     // Macros for CHERIoT in the default and bare-metal ABIs.
     if (ABI == "cheriot" || ABI == "cheriot-baremetal")
-      Builder.defineMacro("__CHERIOT__", "20250215");
+      Builder.defineMacro("__CHERIOT__", "20250217");
     if (ABI == "cheriot-baremetal")
-      Builder.defineMacro("__CHERIOT_BAREMETAL__", "20250215");
+      Builder.defineMacro("__CHERIOT_BAREMETAL__", "20250217");
 
     Builder.defineMacro("__riscv_clen", Twine(getCHERICapabilityWidth()));
     // TODO: _MIPS_CAP_ALIGN_MASK equivalent?
diff --git a/clang/test/CodeGen/cheri/cheri-mcu-call-libcall.c b/clang/test/CodeGen/cheri/cheri-mcu-call-libcall.c
@@ -1,5 +1,5 @@
 // RUN: %clang_cc1 %s -o - "-triple" "riscv32cheriot-unknown-cheriotrtos" "-emit-llvm" "-mframe-pointer=none" "-mcmodel=small" "-target-abi" "cheriot" "-Oz" "-Werror" "-cheri-compartment=example" | FileCheck %s
-#define LIBCALL __attribute__((cheri_libcall))
+#define LIBCALL __attribute__((cheriot_libcall))
 
 LIBCALL
 int add(int a, int b);
diff --git a/clang/test/CodeGen/cheri/cheri-mcu-ccall.c b/clang/test/CodeGen/cheri/cheri-mcu-ccall.c
@@ -1,11 +1,11 @@
 // RUN: %clang_cc1 %s -o - "-triple" "riscv32cheriot-unknown-cheriotrtos" "-emit-llvm" "-mframe-pointer=none" "-mcmodel=small" "-target-abi" "cheriot" "-Oz" "-Werror" "-cheri-compartment=example" | FileCheck %s
 
 // CHECK: define dso_local chericcallcce i32 @_Z5test2ii(i32 noundef %a0, i32 noundef %a1) local_unnamed_addr addrspace(200) #0
-__attribute__((cheri_compartment("example"))) int test2(int a0, int a1) {
+__attribute__((cheriot_compartment("example"))) int test2(int a0, int a1) {
   return a0 + a1;
 }
 
-__attribute__((cheri_compartment("other"))) int test6callee(int *a0, int *a1, int *a2, int *a3, int *a4, int *a5);
+__attribute__((cheriot_compartment("other"))) int test6callee(int *a0, int *a1, int *a2, int *a3, int *a4, int *a5);
 
 int testcall6() {
   static int stack_arg;
diff --git a/clang/test/CodeGen/cheri/cheri-mcu-interrupts.c b/clang/test/CodeGen/cheri/cheri-mcu-interrupts.c
@@ -37,6 +37,13 @@ void default_enable_callback(void)
 {
 }
 
+// CHECK: define dso_local chericcallcc void @default_enable_callback2() local_unnamed_addr addrspace(200) #[[DEFEN]]
+__attribute__((cheriot_ccallback))
+void default_enable_callback2(void)
+{
+}
+
+
 // Explicitly setting interrupt status should override the default
 
 // CHECK: define dso_local chericcallcce noundef i32 @_Z23explicit_disable_calleev() local_unnamed_addr addrspace(200) #[[EXPDIS:[0-9]]]
diff --git a/clang/test/CodeGen/cheri/cheriot-libcall-ptr-decay.c b/clang/test/CodeGen/cheri/cheriot-libcall-ptr-decay.c
@@ -17,7 +17,7 @@ void foo(void (*bar)())
 // CHECK-NEXT:  entry:
 // CHECK-NEXT:    ret void
 //
-void __attribute__((cheri_libcall)) bar()
+void __attribute__((cheriot_libcall)) bar()
 {
         return;
 }
diff --git a/clang/test/CodeGenCXX/cheri/cheriot-libcall-ptr-decay.cpp b/clang/test/CodeGenCXX/cheri/cheriot-libcall-ptr-decay.cpp
@@ -17,7 +17,7 @@ void foo(void (*bar)())
 // CHECK-NEXT:  entry:
 // CHECK-NEXT:    ret void
 //
-void __attribute__((cheri_libcall)) bar()
+void __attribute__((cheriot_libcall)) bar()
 {
         return;
 }
diff --git a/clang/test/Preprocessor/init.c b/clang/test/Preprocessor/init.c
@@ -320,8 +320,8 @@
 // Check for CHERIoT-specific defines
 // RUN: %clang_cc1 %s -o - "-triple" "riscv32-unknown-unknown" "-emit-llvm" "-mframe-pointer=none" "-mcmodel=small" "-target-cpu" "cheriot" "-target-feature" "+xcheri" "-target-feature" "-64bit" "-target-feature" "-relax" "-target-feature" "-xcheri-rvc" "-target-feature" "-save-restore" "-target-abi" "cheriot" -E -dM < /dev/null | FileCheck -check-prefix CHERIOT %s
 // RUN: %clang_cc1 %s -o - "-triple" "riscv32-unknown-unknown" "-emit-llvm" "-mframe-pointer=none" "-mcmodel=small" "-target-cpu" "cheriot" "-target-feature" "+xcheri" "-target-feature" "-64bit" "-target-feature" "-relax" "-target-feature" "-xcheri-rvc" "-target-feature" "-save-restore" "-target-abi" "cheriot-baremetal" -E -dM < /dev/null | FileCheck -check-prefixes CHERIOT,CHERIOT-BAREMETAL %s
-// CHERIOT-BAREMETAL: #define __CHERIOT_BAREMETAL__ 20250215
-// CHERIOT: #define __CHERIOT__ 20250215
+// CHERIOT-BAREMETAL: #define __CHERIOT_BAREMETAL__ 20250217
+// CHERIOT: #define __CHERIOT__ 20250217
 
 
 // RUN: %cheri128_cc1 -fgnuc-version=4.2.1 -E -dM -ffreestanding < /dev/null | FileCheck -check-prefixes CHERI-COMMON,CHERI-MIPS,CHERI128 %s
diff --git a/clang/test/Sema/cheri/cheri-mcu-compartment-warns.c b/clang/test/Sema/cheri/cheri-mcu-compartment-warns.c
@@ -1,13 +1,13 @@
 // RUN: %clang_cc1 %s -o - -triple riscv32cheriot-unknown-cheriotrtos -emit-llvm -mframe-pointer=none -mcmodel=small -target-abi cheriot -Oz -Werror -verify=libcall
 // RUN: %clang_cc1 %s -o - -triple riscv32cheriot-unknown-cheriotrtos -emit-llvm -mframe-pointer=none -mcmodel=small -target-abi cheriot -Oz -Werror -verify=wrong-compartment -cheri-compartment=wrong
 
-__attribute__((cheri_libcall))
+__attribute__((cheriot_libcall))
 int add(int a, int b) // wrong-compartment-error{{CHERI libcall exported from compilation unit for compartment 'wrong' (provided with -cheri-compartment=)}}
 {
 	return a+b;
 }
 
-__attribute__((cheri_compartment("example")))
+__attribute__((cheriot_compartment("example")))
 int shouldBePrototype(void) // libcall-error{{CHERI compartment entry declared for compartment 'example' but implemented in '' (provided with -cheri-compartment=)}} wrong-compartment-error{{CHERI compartment entry declared for compartment 'example' but implemented in 'wrong' (provided with -cheri-compartment=)}}
 {
 	return 1;

Original file line number	Diff line number	Diff line change
`@@ -2564,7 +2564,8 @@ def CHERICCallee : DeclOrTypeAttr { // InheritableAttr {`
`2564`	`2564`	`}`
`2565`	`2565`
`2566`	`2566`	`def CHERICCallback : DeclOrTypeAttr { // InheritableAttr {`
`2567`		`- let Spellings = [GNU<"cheri_ccallback">];`
	`2567`	`+ let Spellings = [GNU<"cheri_ccallback">,`
	`2568`	`+ GNU<"cheriot_ccallback">];`
`2568`	`2569`	`let Documentation = [Undocumented];`
`2569`	`2570`	`}`
`2570`	`2571`
`@@ -2580,14 +2581,17 @@ def CHERIMethodClass : DeclOrTypeAttr { // InheritableAttr {`
`2580`	`2581`	`}`
`2581`	`2582`
`2582`	`2583`	`def CHERICompartmentName : DeclOrTypeAttr {`
`2583`		`- let Spellings = [GNU<"cheri_compartment">];`
	`2584`	`+ let Spellings = [GNU<"cheri_compartment">,`
	`2585`	`+ GNU<"cheriot_compartment">];`
`2584`	`2586`	`let Documentation = [Undocumented];`
`2585`	`2587`	`let Subjects = SubjectList<[Function], ErrorDiag>;`
`2586`	`2588`	`let Args = [StringArgument<"CompartmentName">];`
`2587`	`2589`	`}`
`2588`	`2590`
`2589`	`2591`	`def CHERILibCall : DeclOrTypeAttr {`
`2590`		`- let Spellings = [GNU<"cheri_libcall">];`
	`2592`	`+ let Spellings = [GNU<"cheri_libcall">,`
	`2593`	`+ GNU<"cheriot_libcall">`
	`2594`	`+ ];`
`2591`	`2595`	`let Documentation = [Undocumented];`
`2592`	`2596`	`let Subjects = SubjectList<[Function], ErrorDiag>;`
`2593`	`2597`	`}`
Original file line number	Diff line number	Diff line change
`@@ -37,6 +37,13 @@ void default_enable_callback(void)`
`37`	`37`	`{`
`38`	`38`	`}`
`39`	`39`
	`40`	`+// CHECK: define dso_local chericcallcc void @default_enable_callback2() local_unnamed_addr addrspace(200) #[[DEFEN]]`
	`41`	`+__attribute__((cheriot_ccallback))`
	`42`	`+void default_enable_callback2(void)`
	`43`	`+{`
	`44`	`+}`
	`45`	`+`
	`46`	`+`
`40`	`47`	`// Explicitly setting interrupt status should override the default`
`41`	`48`
`42`	`49`	`// CHECK: define dso_local chericcallcce noundef i32 @_Z23explicit_disable_calleev() local_unnamed_addr addrspace(200) #[[EXPDIS:[0-9]]]`
Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ void foo(void (*bar)())`
`17`	`17`	`// CHECK-NEXT: entry:`
`18`	`18`	`// CHECK-NEXT: ret void`
`19`	`19`	`//`
`20`		`-void __attribute__((cheri_libcall)) bar()`
	`20`	`+void __attribute__((cheriot_libcall)) bar()`
`21`	`21`	`{`
`22`	`22`	`return;`
`23`	`23`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,13 +1,13 @@`
`1`	`1`	`// RUN: %clang_cc1 %s -o - -triple riscv32cheriot-unknown-cheriotrtos -emit-llvm -mframe-pointer=none -mcmodel=small -target-abi cheriot -Oz -Werror -verify=libcall`
`2`	`2`	`// RUN: %clang_cc1 %s -o - -triple riscv32cheriot-unknown-cheriotrtos -emit-llvm -mframe-pointer=none -mcmodel=small -target-abi cheriot -Oz -Werror -verify=wrong-compartment -cheri-compartment=wrong`
`3`	`3`
`4`		`-__attribute__((cheri_libcall))`
	`4`	`+__attribute__((cheriot_libcall))`
`5`	`5`	`int add(int a, int b) // wrong-compartment-error{{CHERI libcall exported from compilation unit for compartment 'wrong' (provided with -cheri-compartment=)}}`
`6`	`6`	`{`
`7`	`7`	`return a+b;`
`8`	`8`	`}`
`9`	`9`
`10`		`-__attribute__((cheri_compartment("example")))`
	`10`	`+__attribute__((cheriot_compartment("example")))`
`11`	`11`	`int shouldBePrototype(void) // libcall-error{{CHERI compartment entry declared for compartment 'example' but implemented in '' (provided with -cheri-compartment=)}} wrong-compartment-error{{CHERI compartment entry declared for compartment 'example' but implemented in 'wrong' (provided with -cheri-compartment=)}}`
`12`	`12`	`{`
`13`	`13`	`return 1;`