avoid showing parasitic errors

Author: andrew-taylor

compile_time_python/explain_compiler_output.py

@@ -106,7 +106,7 @@ def explain_compiler_output(output, args):
         if explanation:
             explanations.append(explanation)
 
-        if run_compile_time_helper(message, args):
+        if explanation and run_compile_time_helper(message, args):
             break
 
         if not explanation_text:
@@ -127,8 +127,10 @@ def explain_compiler_output(output, args):
     #
     # if we didn't explain any messages, just pass through all compiler output
     #
-    if not errors_explained and lines:
-        print("\n".join(lines), file=sys.stderr)
+    if not explanations and lines:
+        message = "\n".join(lines)
+        print(message, file=sys.stderr)
+        run_compile_time_helper(message, args)
 
     return explanations
 

tests/expected_output/nonnull/000001-clang-14.0-x86_64-pc-linux-gnu.txt

@@ -4,7 +4,3 @@ tests/extracted_compile_time_errors/nonnull.c:5:5: warning: argument 2 null wher
       |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
 dcc explanation: you are passing the variable pathname which always contains NULL as argument 2 to 'faccessat'.
 Argument 2 to 'faccessat' should never be NULL.
-In file included from tests/extracted_compile_time_errors/nonnull.c:1:
-/usr/include/unistd.h:309:12: note: in a call to function ‘faccessat’ declared ‘nonnull’
-  309 | extern int faccessat (int __fd, const char *__file, int __type, int __flag)
-      |            ^~~~~~~~~

tests/expected_output/write_null_stream/000001-clang-14.0-x86_64-pc-linux-gnu.txt

@@ -4,11 +4,3 @@ tests/run_time_errors/write_null_stream.c:4:9: warning: argument 1 null where no
       |         ^~~~~~~
 dcc explanation: you are passing a NULL value as argument 1 to 'fprintf'.
 Argument 1 to 'fprintf' should never be NULL.
-In file included from tests/run_time_errors/write_null_stream.c:1:
-/usr/include/stdio.h:350:12: note: in a call to function ‘fprintf’ declared ‘nonnull’
-  350 | extern int fprintf (FILE *__restrict __stream,
-      |            ^~~~~~~
-tests/run_time_errors/write_null_stream.c:4:9: warning: argument 4 null where non-null expected [-Wnonnull]
-    4 |         fprintf(NULL, "Hello world\n");
-      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-tests/run_time_errors/write_null_stream.c:4:9: note: in a call to built-in function ‘__builtin_fwrite’