Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in DataHandler while deleting specific pages #2

Open
dwenzel opened this issue Sep 24, 2019 · 2 comments
Open

Error in DataHandler while deleting specific pages #2

dwenzel opened this issue Sep 24, 2019 · 2 comments

Comments

@dwenzel
Copy link
Member

dwenzel commented Sep 24, 2019

Method TYPO3\CMS\Core\DataHandling\DataHandler->deleteSpecificPage fails when vcc is installed.

This method loops through all tables in $GLOBALS['TCA'] and tries to find any records on a specific page searching by column pid

Table tx_scheduler_task does't have a field pid. Therefore the database query fails:

'SELECT uid FROM tx_scheduler_task WHERE pid = ?' with params
[1297]: Unknown column 'pid' in 'where clause'

The extension scheduler doesn't register tx_scheduler_task with TCA but vcc does extend it.
This seems to be the reason why it fails...

Thanks @meisterkaiser for reporting.

@dwenzel
Copy link
Member Author

dwenzel commented Sep 24, 2019

@IchHabRecht The TCA overrides were added with commit 4070440158.

I guess they came from vcc_plus.

Does this extension still exist?
How did it handle the issue described above?
thx in advance.

@dwenzel
Copy link
Member Author

dwenzel commented Sep 24, 2019

addenum:

Allthough the method deleteSpecificPages is declared public it is annotated @access private and seems to be used in DataHandler->deletePages only . There a condition prevents further processing if the uid of the page to delete is 0.

It might work to just add a field pid to tx_scheduler_task, assuming this is the only call of our public private method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant