From 3b7576f320c31cfb6e8aff6bdc5dfcbdd6c2685b Mon Sep 17 00:00:00 2001 From: seungwonme Date: Tue, 6 Feb 2024 13:27:10 +0900 Subject: [PATCH 1/3] PR --- PR.md | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 PR.md diff --git a/PR.md b/PR.md new file mode 100644 index 0000000..4b5d84e --- /dev/null +++ b/PR.md @@ -0,0 +1,3 @@ +Pull Request를 만들기 위한 파일입니다. + +댓글을 달 수 있습니다. From 0a95d04fb40667b8161da2983fcfc8395fd4ca1b Mon Sep 17 00:00:00 2001 From: seungwonme Date: Tue, 6 Feb 2024 14:21:57 +0900 Subject: [PATCH 2/3] Created CODEOWNERS --- .github/CODEOWNERS | 68 ++++++++++++++++++++++++++++++++++++++++++++++ README.md | 8 +++++- 2 files changed, 75 insertions(+), 1 deletion(-) create mode 100644 .github/CODEOWNERS diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS new file mode 100644 index 0000000..02e87a1 --- /dev/null +++ b/.github/CODEOWNERS @@ -0,0 +1,68 @@ +# CODEOWNERS로 코드 리뷰어 지정하기 +* @seungwonme + +# This is a comment. +# Each line is a file pattern followed by one or more owners. + +# These owners will be the default owners for everything in +# the repo. Unless a later match takes precedence, +# @global-owner1 and @global-owner2 will be requested for +# review when someone opens a pull request. + + +# Order is important; the last matching pattern takes the most +# precedence. When someone opens a pull request that only +# modifies JS files, only @js-owner and not the global +# owner(s) will be requested for a review. + + +# You can also use email addresses if you prefer. They'll be +# used to look up users just like we do for commit author +# emails. + + +# Teams can be specified as code owners as well. Teams should +# be identified in the format @org/team-name. Teams must have +# explicit write access to the repository. In this example, +# the octocats team in the octo-org organization owns all .txt files. + + +# In this example, @doctocat owns any files in the build/logs +# directory at the root of the repository and any of its +# subdirectories. + + +# The `docs/*` pattern will match files like +# `docs/getting-started.md` but not further nested files like +# `docs/build-app/troubleshooting.md`. + + +# In this example, @octocat owns any file in an apps directory +# anywhere in your repository. + + +# In this example, @doctocat owns any file in the `/docs` +# directory in the root of your repository and any of its +# subdirectories. + + +# In this example, any change inside the `/scripts` directory +# will require approval from @doctocat or @octocat. + + +# In this example, @octocat owns any file in a `/logs` directory such as +# `/build/logs`, `/scripts/logs`, and `/deeply/nested/logs`. Any changes +# in a `/logs` directory will require approval from @octocat. + + +# In this example, @octocat owns any file in the `/apps` +# directory in the root of your repository except for the `/apps/github` +# subdirectory, as its owners are left empty. + + + +# In this example, @octocat owns any file in the `/apps` +# directory in the root of your repository except for the `/apps/github` +# subdirectory, as this subdirectory has its own owner @doctocat + + diff --git a/README.md b/README.md index c6be54f..1a4b371 100644 --- a/README.md +++ b/README.md @@ -8,12 +8,18 @@ ![](./img/GitWorkflow.png) -## Git Branch Model +## Git Branch + +### Git Branch Model - [{Git,Github,Gitlab} Flow 1](https://ujuc.github.io/2015/12/16/git-flow-github-flow-gitlab-flow/) - [{Git,Github,Gitlab} Flow 2](https://wiki.yowu.dev/ko/dev/Git/about-git-github-gitlab-flow) - [Trunk Based Development](https://trunkbaseddevelopment.com) - [Trunk Based Development 기술 블로그](https://tech.mfort.co.kr/blog/2022-08-05-trunk-based-development/) +### Git Branch Policy +- [Branch Protection Rule](https://docs.github.com/ko/repositories/configuring-branches-and-merges-in-your-repository/managing-protected-branches/managing-a-branch-protection-rule) +- [CODEOWNERS file](https://docs.github.com/ko/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners) + ## Git Command ### restore From 020729d5f5fdda0bc26c7a9fb96c2426016cc5bd Mon Sep 17 00:00:00 2001 From: seungwonme Date: Tue, 6 Feb 2024 14:24:24 +0900 Subject: [PATCH 3/3] Modified CODEOWNERS --- .github/CODEOWNERS | 40 ++++++++++++++++++++++++++-------------- 1 file changed, 26 insertions(+), 14 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 02e87a1..fd55bef 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -8,61 +8,73 @@ # the repo. Unless a later match takes precedence, # @global-owner1 and @global-owner2 will be requested for # review when someone opens a pull request. - + +# * @global-owner1 @global-owner2 # Order is important; the last matching pattern takes the most # precedence. When someone opens a pull request that only # modifies JS files, only @js-owner and not the global # owner(s) will be requested for a review. - + +# *.js @js-owner #This is an inline comment. # You can also use email addresses if you prefer. They'll be # used to look up users just like we do for commit author # emails. - + +# *.go docs@example.com # Teams can be specified as code owners as well. Teams should # be identified in the format @org/team-name. Teams must have # explicit write access to the repository. In this example, # the octocats team in the octo-org organization owns all .txt files. - + +# *.txt @octo-org/octocats # In this example, @doctocat owns any files in the build/logs # directory at the root of the repository and any of its # subdirectories. - + +# /build/logs/ @doctocat # The `docs/*` pattern will match files like # `docs/getting-started.md` but not further nested files like # `docs/build-app/troubleshooting.md`. - + +# docs/* docs@example.com # In this example, @octocat owns any file in an apps directory # anywhere in your repository. - + +# apps/ @octocat # In this example, @doctocat owns any file in the `/docs` # directory in the root of your repository and any of its # subdirectories. - + +# /docs/ @doctocat # In this example, any change inside the `/scripts` directory # will require approval from @doctocat or @octocat. - + +# /scripts/ @doctocat @octocat # In this example, @octocat owns any file in a `/logs` directory such as # `/build/logs`, `/scripts/logs`, and `/deeply/nested/logs`. Any changes # in a `/logs` directory will require approval from @octocat. - + +# **/logs @octocat # In this example, @octocat owns any file in the `/apps` # directory in the root of your repository except for the `/apps/github` # subdirectory, as its owners are left empty. - - + +# /apps/ @octocat +# /apps/github # In this example, @octocat owns any file in the `/apps` # directory in the root of your repository except for the `/apps/github` # subdirectory, as this subdirectory has its own owner @doctocat - - + +# /apps/ @octocat +# /apps/github @doctocat