Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve DynObj module, add tests #30

Closed
kMutagene opened this issue Sep 6, 2024 · 1 comment · Fixed by #32
Closed

Improve DynObj module, add tests #30

kMutagene opened this issue Sep 6, 2024 · 1 comment · Fixed by #32
Assignees
@kMutagene

Comments

@kMutagene
Copy link
Member

image

image

In most cases i'd suggest having the DynamicObj as the last arg
@github-actions github-actions bot added the Status: Needs Triage This item is up for investigation. label Sep 6, 2024
@kMutagene kMutagene self-assigned this Sep 10, 2024
@kMutagene kMutagene moved this to In progress in ARCStack Sep 10, 2024
@kMutagene kMutagene removed the Status: Needs Triage This item is up for investigation. label Sep 10, 2024
@kMutagene
Copy link
Member Author

Using this as a starter to improve the whole the module and add various tests.

@kMutagene kMutagene changed the title Different arg order of DynObj TryGetValue and TryGetTypedValue<'T> Improve DynObj module, add tests Sep 10, 2024
@kMutagene kMutagene linked a pull request Sep 10, 2024 that will close this issue
DynObj rework and various tests #32
Merged
4 tasks
@github-project-automation github-project-automation bot moved this from In review to Done in ARCStack Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kMutagene kMutagene

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DynObj rework and various tests CSBiology/DynamicObj
1 participant
@kMutagene