-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Elections Info #25
Comments
This task will eventually culminate in moving all the elections data to the new site from the csss-site github repo https://github.com/CSSS/csss-site/tree/master/csss-site/src/elections To start this task, break it into smaller tasks that can be accomplished without access to the data, and that can be tested locally & manually. For example, you might do the following:
|
What exactly is the slug type referred to here? Edit: nvm read some documentation, this specific implementation is a django type, so i'll just treat it as a unique String |
Yeah! Slugs as a feature are pretty common, but I would def treat it as just a string. Not sure what the Django type is, but string is much easier to understand :) |
Looks awesome! The layout makes a lot of sense, I can't think of anything missing. I'd love to render the other tables in this way as well. In your opinion, what's the biggest change wrt to the old tables? |
@DerpyWasHere , amazing chart for the DB stuff - cardinalities look good, info is good. Really excited to see where this goes from here!! |
Although actually, election_nominee looks like it holds a subset of info held by a user in the user table, do you want to keep these separate or maybe take advantage of the user table a little? |
I did consider this actually; since elections_nominee is independent of a specific election, it would make more sense for the table to be included under Maybe the best course of action would be to move the table to |
But now it makes me think, maybe But more importantly, we will need to store which positions the user is applying for under |
Good points! I'll leave it to y'all to decide. |
Wrt which socials to have public or not, could we not just have that behaviour hinge on the data existing? Haha oops forgot to store the position tehe |
probably! That sounds like a good way to do it. Once the frontend is implemented by @micahdbak, he can make requests based on the user experience that'll makes the most sense. |
IMO you can just place socials information as possibly empty attributes (if they're private - keep them null) and return the attributes as empty or not even included in the endpoint that serves info about the election candidate |
I thought of a few more features that we'll want to have. These need not be part of the MVP, but should eventually exist:
|
Could I get a list or example of what public and private election data look like? Actually, now that I think about it. How should we go about saving/reading the actual election results data, should we just make another table or read it from whatever the source is? |
Before an election starts, nominee_speech data should be private. Only once a specific datetime (election start time) passes, is the data accessible through the API. election_nominee data should be thought of as unlisted, as it can't be accessed unless there is an election that points at it. However, this brings up the question; should the past officer info change with for past elections or not? If it did change, it would be a little unwelcome, as the data seems private, but anyone can actually see it change in real time. There are several ways to go about this, and I'm not sure which feels best. Maybe attach socials to election_speech 1:1?
Probably just store it as two fields; raw string + parsed results (also string). If so, we can extend it to something more complicated in the future. |
FYI, it's up to you the order you think is best to implement this :) Stage 1
Stage 2 (optional)
Stage 3
// I suggest 1 PR per 1-2 checkboxes |
We'll need database tables to store past elections, enable admins to appoint an elections officer, allow elections officer to configure an election, and to allow logged in student to run for executive positions.
TODO: add more issues for the above tasks
The text was updated successfully, but these errors were encountered: