🐞 Refactor - CLI models should use dataclass instead of init (Election-Tech-Initiative#670)

dataclass autogenerates the exact same init since there is no specialization on these files. This shortens the classes down and simplifies constructors.

Co-authored-by: Lee Richardson <[email protected]>

Author: keithrfung

src/electionguard_cli/cli_models/cli_decrypt_results.py

@@ -1,24 +1,14 @@
+from dataclasses import dataclass
 from typing import Dict
 from electionguard.tally import CiphertextTally, PlaintextTally
 from electionguard.type import BallotId
 from electionguard.election_polynomial import LagrangeCoefficientsRecord
 
 
+@dataclass
 class CliDecryptResults:
     """Responsible for holding the results of decrypting an election."""
 
-    def __init__(
-        self,
-        plaintext_tally: PlaintextTally,
-        plaintext_spoiled_ballots: Dict[BallotId, PlaintextTally],
-        ciphertext_tally: CiphertextTally,
-        lagrange_coefficients: LagrangeCoefficientsRecord,
-    ):
-        self.plaintext_tally = plaintext_tally
-        self.plaintext_spoiled_ballots = plaintext_spoiled_ballots
-        self.ciphertext_tally = ciphertext_tally
-        self.lagrange_coefficients = lagrange_coefficients
-
     plaintext_tally: PlaintextTally
     plaintext_spoiled_ballots: Dict[BallotId, PlaintextTally]
     ciphertext_tally: CiphertextTally

src/electionguard_cli/cli_models/e2e_build_election_results.py

@@ -1,15 +1,12 @@
+from dataclasses import dataclass
+
 from electionguard.election import CiphertextElectionContext
 from electionguard.manifest import InternalManifest
 
 
+@dataclass
 class BuildElectionResults:
     """The results of building an election, more specifically an internal manifest and context."""
 
-    def __init__(
-        self, internal_manifest: InternalManifest, context: CiphertextElectionContext
-    ):
-        self.internal_manifest = internal_manifest
-        self.context = context
-
     internal_manifest: InternalManifest
     context: CiphertextElectionContext

src/electionguard_cli/cli_models/encrypt_results.py

@@ -1,18 +1,12 @@
+from dataclasses import dataclass
 from typing import List
 from electionguard.ballot import CiphertextBallot
 from electionguard.encrypt import EncryptionDevice
 
 
+@dataclass
 class EncryptResults:
     """Responsible for holding the results of encrypting votes in an election."""
 
-    def __init__(
-        self,
-        device: EncryptionDevice,
-        ciphertext_ballots: List[CiphertextBallot],
-    ):
-        self.device = device
-        self.ciphertext_ballots = ciphertext_ballots
-
     device: EncryptionDevice
     ciphertext_ballots: List[CiphertextBallot]