Skip to content

Commit 90272d6

Browse files
authored
Merge pull request #268 from CacheControl/upgrade-deps
2 parents 2fa2862 + cb71774 commit 90272d6

File tree

5 files changed

+17
-15
lines changed

5 files changed

+17
-15
lines changed

.github/workflows/node.js.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616

1717
strategy:
1818
matrix:
19-
node-version: [10.x, 12.x, 14.x]
19+
node-version: [12.x, 14.x]
2020

2121
steps:
2222
- uses: actions/checkout@v2

examples/09-rule-results.js

+2
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,8 @@ async function start () {
5252
return `was not an ${condition.fact}`
5353
case 'greaterThanInclusive':
5454
return `${condition.fact} of ${condition.factResult} was too low`
55+
default:
56+
return ''
5557
}
5658
}).join(' and ')
5759
console.log(`${message} ${detail}`.red)

examples/support/account-api-client.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ const accountData = {
2828
*/
2929
module.exports = {
3030
getAccountInformation: (accountId) => {
31-
var message = 'loading account information for "' + accountId + '"'
31+
const message = 'loading account information for "' + accountId + '"'
3232
console.log(message.dim)
3333
return new Promise((resolve, reject) => {
3434
setImmediate(() => {

package.json

+12-12
Original file line numberDiff line numberDiff line change
@@ -64,29 +64,29 @@
6464
"babel-cli": "6.26.0",
6565
"babel-core": "6.26.3",
6666
"babel-eslint": "10.1.0",
67-
"babel-loader": "8.1.0",
67+
"babel-loader": "8.2.2",
6868
"babel-polyfill": "6.26.0",
6969
"babel-preset-es2015": "~6.24.1",
7070
"babel-preset-stage-0": "~6.24.1",
7171
"babel-register": "6.26.0",
72-
"chai": "^4.2.0",
72+
"chai": "^4.3.4",
7373
"chai-as-promised": "^7.1.1",
7474
"colors": "~1.4.0",
7575
"dirty-chai": "2.0.1",
76-
"lodash": "4.17.20",
77-
"mocha": "^8.1.3",
76+
"lodash": "4.17.21",
77+
"mocha": "^8.4.0",
7878
"perfy": "^1.1.5",
79-
"sinon": "^9.0.3",
80-
"sinon-chai": "^3.5.0",
81-
"snazzy": "^8.0.0",
82-
"standard": "^14.3.4",
83-
"tsd": "^0.13.1"
79+
"sinon": "^11.1.1",
80+
"sinon-chai": "^3.7.0",
81+
"snazzy": "^9.0.0",
82+
"standard": "^16.0.3",
83+
"tsd": "^0.17.0"
8484
},
8585
"dependencies": {
8686
"clone": "^2.1.2",
87-
"eventemitter2": "^6.4.3",
88-
"hash-it": "^4.0.5",
89-
"jsonpath-plus": "^4.0.0",
87+
"eventemitter2": "^6.4.4",
88+
"hash-it": "^5.0.0",
89+
"jsonpath-plus": "^5.0.7",
9090
"lodash.isobjectlike": "^4.0.0"
9191
}
9292
}

src/engine.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ class Engine extends EventEmitter {
209209
return Promise.all(ruleArray.map((rule) => {
210210
if (this.status !== RUNNING) {
211211
debug(`engine::run status:${this.status}; skipping remaining rules`)
212-
return
212+
return Promise.resolve()
213213
}
214214
return rule.evaluate(almanac).then((ruleResult) => {
215215
debug(`engine::run ruleResult:${ruleResult.result}`)

0 commit comments

Comments
 (0)