Skip to content

Commit f88756a

Browse files
author
Cache Hamm
committed
Update types for updateRule and removeRule
1 parent 8aa5b8b commit f88756a

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

types/index.d.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,8 @@ export class Engine {
2020
constructor(rules?: Array<RuleProperties>, options?: EngineOptions);
2121

2222
addRule(rule: RuleProperties): this;
23-
removeRule(rule: Rule): boolean;
23+
removeRule(ruleOrName: Rule | string): boolean;
24+
updateRule(rule: Rule): void;
2425

2526
addOperator(operator: Operator): Map<string, Operator>;
2627
addOperator<A, B>(

types/index.test-d.ts

+1
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ const rule: Rule = new Rule(ruleProps);
5858
const ruleFromString: Rule = new Rule(JSON.stringify(ruleProps));
5959
expectType<Engine>(engine.addRule(rule));
6060
expectType<boolean>(engine.removeRule(ruleFromString));
61+
expectType<void>(engine.updateRule(ruleFromString));
6162

6263
expectType<Rule>(rule.setConditions({ any: [] }));
6364
expectType<Rule>(rule.setEvent({ type: "test" }));

0 commit comments

Comments
 (0)