Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule Ts incorrect #253

Open
set321go opened this issue Feb 17, 2021 · 0 comments
Open

Rule Ts incorrect #253

set321go opened this issue Feb 17, 2021 · 0 comments
Milestone

Comments

@set321go
Copy link

set321go commented Feb 17, 2021

The rule.js recently refactored the rule.event property to rule.ruleEvent (80e84b3) but there were no corresponding updates to the types when using the types accessing the property directly does not work as expected.

Should the type use rule.ruleEvent or should it use accessors for the event?

js & ts are not my speciality but i think the 'event' property of the interface needs to have a get function & set function that are actually the getEvent and setEvent functions.

@chris-pardy chris-pardy added this to the version 7 milestone Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants