[pacman] Add commented ILoveCandy #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ILoveCandy is part of core pacman but yeah we can add this to the makepkg.conf |
1Naim
approved these changes
Oct 16, 2024
|
Why do we want this? This is actually already set in the install pacman config: |
|
My thinking was mainly for posterity in the pacman.conf provided by the package itself, considering all the other options have the comments too. |
|
It is not included in the .pacnew whenever pacman has an update |
|
Thats an argument |
ptr1337
approved these changes
Oct 16, 2024
1Naim
requested changes
Oct 20, 2024
vnepogodin
approved these changes
Oct 26, 2024
PrettyProgressBar patch includes an option for ILoveCandy and isn't included in the config. All the other options are already added here. Signed-off-by: Eric Naim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PrettyProgressBar patch includes an option for ILoveCandy and isn't included in the config. All the other options are already added here.