Workaround to prevent ghost objects while dragging notes in bomb placement mode

XAce1337manX · XAce1337manX · commit fd7d14896232 · 2024-12-15T16:55:30.000+10:00
diff --git a/Assets/__Scripts/MapEditor/Mapping/PlacementControllers/NotePlacement.cs b/Assets/__Scripts/MapEditor/Mapping/PlacementControllers/NotePlacement.cs
@@ -172,7 +172,9 @@ public void UpdateCut(int value)
             DraggedObjectContainer.NoteData.CutDirection = value;
             noteAppearanceSo.SetNoteAppearance(DraggedObjectContainer);
         }
-        else if (beatmapNoteInputController.QuickModificationActive && Settings.Instance.QuickNoteEditing)
+        // TODO: This IsActive is a workaround to prevent ghost notes. This happens because bomb placement could be
+        //       dragging a note and quick editing results in issues
+        else if (IsActive && beatmapNoteInputController.QuickModificationActive && Settings.Instance.QuickNoteEditing)
         {
             var note = ObjectUnderCursor();
             if (note != null && note.ObjectData is BaseNote noteData)

Original file line number	Diff line number	Diff line change
`@@ -172,7 +172,9 @@ public void UpdateCut(int value)`
`172`	`172`	`DraggedObjectContainer.NoteData.CutDirection = value;`
`173`	`173`	`noteAppearanceSo.SetNoteAppearance(DraggedObjectContainer);`
`174`	`174`	`}`
`175`		`- else if (beatmapNoteInputController.QuickModificationActive && Settings.Instance.QuickNoteEditing)`
	`175`	`+ // TODO: This IsActive is a workaround to prevent ghost notes. This happens because bomb placement could be`
	`176`	`+ // dragging a note and quick editing results in issues`
	`177`	`+ else if (IsActive && beatmapNoteInputController.QuickModificationActive && Settings.Instance.QuickNoteEditing)`
`176`	`178`	`{`
`177`	`179`	`var note = ObjectUnderCursor();`
`178`	`180`	`if (note != null && note.ObjectData is BaseNote noteData)`