Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reintroduce n_c_and_cpp example #229

Open
jwallwork23 opened this issue Jan 13, 2025 · 3 comments
Open

Reintroduce n_c_and_cpp example #229

jwallwork23 opened this issue Jan 13, 2025 · 3 comments
Labels
documentation Improvements or additions to documentation

Comments

@jwallwork23
Copy link
Contributor

jwallwork23 commented Jan 13, 2025 •
edited
Loading

There was an unfinished C and C++ example in FTorch for some time. The draft code can be found in #230, which removed this example.

          Not for this PR but I wonder if we should remove this demo from the `main` branch and open an issue that would finish it? It's neither complete nor tested so perhaps not suited in v1.0.

Originally posted by @jwallwork23 in #228 (comment)
@jwallwork23 jwallwork23 self-assigned this Jan 13, 2025
jwallwork23 added a commit that referenced this issue Jan 13, 2025
@jwallwork23
#229: Drop n_c_and_cpp example for now
1ad2087
@jwallwork23 jwallwork23 mentioned this issue Jan 13, 2025
Merged
@jatkinson1000
Copy link
Member

@jwallwork23 Should this be closed?
Looks like it didn't get tied to #230

@jwallwork23
Copy link
Contributor Author

Ah, I guess it isn't very clear. I meant for this issue to be the one for reintroducing that demo. I'll give it a better title.

@jwallwork23 jwallwork23 changed the title Remove n_c_and_cpp demo until finished Reintroduce n_c_and_cpp example Jan 14, 2025
@jwallwork23 jwallwork23 added the documentation Improvements or additions to documentation label Jan 14, 2025
@jwallwork23
Copy link
Contributor Author

Updated the description, too.

@jwallwork23 jwallwork23 removed their assignment Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jwallwork23 @jatkinson1000