Merge pull request #14 from Cambridge-ICCS/impl3

Implement `equation_of_line` using SymPy
Cambridge-ICCS · Jul 10, 2024 · caa0d3a · caa0d3a
2 parents c947660 + 189b9d3
commit caa0d3a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/maths.py b/maths.py
@@ -1,3 +1,4 @@
+from sympy import Line, Point2D
 import numpy as np
 
 
@@ -11,10 +12,9 @@ def equation_of_line(a, b):
     """
     if np.allclose(a, b):
         raise ValueError("Cannot determine a unique line through {a} and {b}.")
-    x0, y0 = a
-    x1, y1 = b
+    line = Line(Point2D(a), Point2D(b))
 
-    def f(x, y):
-        return (x1 - x0) * (y - y0) - (y1 - y0) * (x - x0)
+    def evaluate(x, y):
+        return float(line.distance(Point2D((x, y))))
 
-    return f
+    return evaluate
diff --git a/requirements.txt b/requirements.txt
@@ -1,2 +1,3 @@
 numpy
 pytest
+sympy
-Original file line number
+Diff line change
@@ -1,2 +1,3 @@
     numpy
     pytest
+    sympy