Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor NostraDataParser methods to class methods and update StarknetClient to use FullNodeClient #452

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MrRoudyk
Copy link
Contributor

@MrRoudyk MrRoudyk commented Feb 21, 2025

Closes #439

Protocol Address Updates:

  • Added new protocol addresses to ProtocolAddresses class in constants.py to support additional contracts. [1] [2] [3] [4] [5] [6]

Event Mapping Updates:

  • Updated NOSTRA_EVENTS_MAPPING and NOSTRA_MAINNET_EVENTS_TO_METHODS to improve readability by consolidating lines and adding new event mappings. [1] [2]
  • Updated NOSTRA_MAINNET_ADDRESSES_TO_EVENTS to include new mappings for interest-bearing and non-interest-bearing collateral events. [1] [2]

Method Refactoring:

  • Converted several instance methods to class methods in nostra.py to improve code structure and maintainability. [1] [2] [3]

Minor Code Cleanups:

  • Removed unnecessary imports and reorganized import statements for better code clarity in events.py.
  • Minor formatting adjustments in nostra_mainnet_settings.py for better readability. [1] [2] [3]

@djeck1432 djeck1432 self-requested a review February 22, 2025 07:15
@djeck1432 djeck1432 linked an issue Feb 22, 2025 that may be closed by this pull request
@MrRoudyk MrRoudyk force-pushed the feat/439-nostra-mainnet-validation branch 2 times, most recently from 65a4ab5 to ce586e8 Compare February 22, 2025 20:58
@MrRoudyk MrRoudyk force-pushed the feat/439-nostra-mainnet-validation branch from ce586e8 to a284ea0 Compare February 23, 2025 09:15
@MrRoudyk MrRoudyk marked this pull request as ready for review February 23, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DataHandler] Nostra mainnet validate logic after recently changes
1 participant