[UI] Consistent actions UI in main and card views

[ckardaris]

For consistency of the UI the card actions should look the same in the main and card view respectively.

Current main view

Current card view

Proposal

• Move the edit button of the card view (circled), to the top bar like it is in main view. Being on the bottom seemed a little counter-intuitive during my initial usage of the app.
• Show the "Add to favorites" start icon in the main view as well (similarly to the card view).

That way we can have the same 3 icons visible in both views: Edit, Share, Add to favorites.

[TheLastProject]

Move the edit button of the card view (circled), to the top bar like it is in main view. Being on the bottom seemed a little counter-intuitive during my initial usage of the app.

That is definitely not changing like that. Using a "Floating Action Button" for the default action is the correct Material You design. Putting it in the top right is very outdated Android 4 design language. It may move a bit in the bottom when this will probably use a Material 3 toolbar for the Material 3 redesign, but it will stay on the bottom.

Show the "Add to favorites" start icon in the main view as well (similarly to the card view).

You can select multiple cards in the home screen, which is why it's "Add to favorites" and "Remove from favorites". If they're displayed depends on if there are any selected cards left non-favorited (to favorite) or favorites (to non-favorite). It would be possible to use the star directly if there is only one card selected, but then you have inconsistency if you select one or multiple cards. But seems acceptable but low priority.

[TheLastProject]

I'm honestly tempted to say "wontfix" because adding a special edge case for selecting a single card with favoriting and archiving does complicate the code a fair bit for quite a minimal cosmetic gain 😅

[ckardaris]

Move the edit button of the card view (circled), to the top bar like it is in main view. Being on the bottom seemed a little counter-intuitive during my initial usage of the app.

That is definitely not changing like that. Using a "Floating Action Button" for the default action is the correct Material You design. Putting it in the top right is very outdated Android 4 design language. It may move a bit in the bottom when this will probably use a Material 3 toolbar for the Material 3 redesign, but it will stay on the bottom.

This makes sense. I admit I am not entirely familiar with "Material You" design. I understand the reasoning now. Aligning the button with the next/previous card buttons would be good I guess.

Show the "Add to favorites" start icon in the main view as well (similarly to the card view).

You can select multiple cards in the home screen, which is why it's "Add to favorites" and "Remove from favorites". If they're displayed depends on if there are any selected cards left non-favorited (to favorite) or favorites (to non-favorite). It would be possible to use the star directly if there is only one card selected, but then you have inconsistency if you select one or multiple cards. But seems acceptable but low priority.

Thanks, I understand what decision lead to the current UI. As you suggest, I think showing the star if there is one card selected would be better.

[TheLastProject]

I guess I'll leave it open as a low-priority enhancement to use the icon if only one card is selected. But #2768 should probably be finished first for consistency :)

I likely won't pick this up but contributions welcome :)

[ckardaris]

@TheLastProject I tried to implement this some time ago and I had two observations:

• As you already mentioned, creating the logic for showing the single favorite button (with the corresponding icon if visible) and hiding the Add/Remove from favorites buttons complicated the code quite a bit for small benefit.
• The benefit became even smaller when I noticed that the star icon, being 3rd in the hierarchy after the edit and share buttons, would not even show on my phone in vertical mode due to lack of space. It would be collapsed to list.

So, it turns out that for me personally, this is not very useful anymore, unless we would increase the priority of the star action above the 'share' action.

Otherwise, and unless you think it would be good to have this, you can close this issue.