agent deployment status: remove orphaned files after grace period

CMK-15880

Change-Id: I41443504b7326d5dc7839f71428cd3ba677d04b6

Author: SoloJacobs

cmk/diskspace/abandoned.py

@@ -118,6 +118,20 @@ def _do_cleanup_central_site(
         )
     )
 
+    # The invocation `cmk-update-agent register --hostname myhost ...` will unconditionally create
+    # these files, and they can be used afterwards by creating the host. So, a user might first do
+    # the registration and then the site configuration. However, its is unlikely this file is useful
+    # after more than a day.
+    # Note: All these files only exist on the central site. If a host is deleted, then these files
+    # are deleted via the `delete-host` automation. If a host is moved between sites, then these
+    # files remain where they are, so diskspace does not need special logic for those cases.
+    _cleanup_host_directories(
+        time.time(),
+        retention_time,
+        all_hosts,
+        f"{omd_root}/var/check_mk/agent_deployment/",
+    )
+
     if cleaned_up_deleted_hosts := cleaned_up - all_hosts:
         _do_automation_call(cleaned_up_deleted_hosts, "delete-hosts")
     if cleaned_up_remote_hosts := cleaned_up & (all_hosts - local_site_hosts):

cmk/gui/wato/_omd_configuration.py

@@ -338,7 +338,10 @@ def valuespec(self) -> ValueSpec:
                             "site to another or deleting a host manually from the configuration.<br>"
                             "The performance data (RRDs) and HW/SW Inventory archive are never deleted "
                             "during host deletion. They are only deleted automatically when you enable "
-                            "this option and after the configured period."
+                            "this option and after the configured period. "
+                            "This option also affects the retention of `Agent update status` files. "
+                            "These files can be created without a corresponding host, but should "
+                            "be cleaned up after a grace period if the user never creates the host."
                         ),
                     ),
                 ),