http: align v1_scheme with ruleset

Change-Id: I300faf702061ca82dc9beb6c630e4bd4f6d37fb9
Checkmk · Feb 11, 2025 · 363b205 · 363b205
1 parent 8db181c
commit 363b205
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/cmk/update_config/http/v1_scheme.py b/cmk/update_config/http/v1_scheme.py
@@ -5,7 +5,7 @@
 
 from typing import Literal
 
-from pydantic import BaseModel
+from pydantic import BaseModel, Field
 
 
 class V1Proxy(BaseModel, extra="forbid"):
@@ -23,7 +23,7 @@ class V1Host(BaseModel, extra="forbid"):
     # true, if client_cert is true, client private key or -S is enabled. On redirect new ports might
     # be defined. This behaviour will not transfer to the new check, most likely.
     port: int | None = None
-    virthost: str | None = None
+    virthost: str | None = Field(default=None, min_length=1)
 
 
 class V1Auth(BaseModel, extra="forbid"):

diff --git a/tests/unit/cmk/update_config/http/test_migrate.py b/tests/unit/cmk/update_config/http/test_migrate.py
@@ -742,6 +742,12 @@
     ),
 }
 
+EXAMPLE_92: Mapping[str, object] = {
+    "name": "authorization",
+    "host": {"address": ("direct", "[::1]"), "virthost": ""},
+    "mode": ("url", {}),
+}
+
 
 @pytest.mark.parametrize(
     "rule_value",
@@ -1186,6 +1192,13 @@ def test_migrate_ssl(rule_value: Mapping[str, object], expected: str) -> None:
                 mode_fields=["onredirect", "expect_response"],
             ),
         ),
+        (
+            EXAMPLE_92,
+            Conflict(
+                type_="invalid_value",
+                cant_load=True,
+            ),
+        ),
     ],
 )
 def test_detect_conflicts(rule_value: Mapping[str, object], conflict: Conflict) -> None: