17558 FIX mbg_lantime_ng_refclock: Fix KeyError(170)

SUP-22333

Change-Id: I2df94e13cefa9c6663ee02f6e1e52ff6492b2575

Author: SoloJacobs

.werks/17558.md

@@ -0,0 +1,27 @@
+[//]: # (werk v2)
+# mbg_lantime_ng_refclock: Fix KeyError(170)
+
+key        | value
+---------- | ---
+date       | 2025-02-06T09:06:33+00:00
+version    | 2.3.0p27
+class      | fix
+edition    | cre
+component  | checks
+level      | 1
+compatible | yes
+
+Previously, the following crash could occur:
+```
+ File "/omd/sites/{site}/share/check_mk/checks/mbg_lantime_ng_refclock", line 208, in mbg_lantime_ng_generalstate
+    detailed_state_txt = " (%s)" % refclock_substates[substate] if substate != "0" else ""
+ KeyError: 170
+```
+The following states from MBG-SNMP-LTNG-MIB::mbgLtNgRefclockSubstate have been added:
+
+* mrsRefNone(-1),
+* mrsVideoInSync(168),
+* mrsLtcSync(169),
+* mrsOscSync(170)
+
+In particular, the check will no longer crash upon encountering such a state.

cmk/base/legacy_checks/mbg_lantime_ng_refclock.py

@@ -171,6 +171,7 @@ def mbg_lantime_ng_generalstate(clock_type, usage, state, substate):
 
     # Translation for values of MBG-SNMP-LTNG-MIB::mbgLtNgRefclockSubstate
     refclock_substates = {
+        "-1": "MRS Ref None",
         "0": "not available",
         "1": "GPS sync",
         "2": "GPS tracking",
@@ -202,6 +203,9 @@ def mbg_lantime_ng_generalstate(clock_type, usage, state, substate):
         "165": "MRS HAVE QUICK sync",
         "166": "MRS external oscillator sync",
         "167": "MRS SyncE",
+        "168": "MRS video in sync",
+        "169": "MRS ltc sync",
+        "170": "MRS osc sync",
     }
 
     state, state_txt = refclock_states[state]